[HDDS-8008] Move pendingOps into ContainerStateManagerImpl to ensure consistent state

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Component/s: SCM
• Labels: pull-request-available
• Assignee: Stephen O'Donnell
• Reporter: Stephen O'Donnell
• Created: 22/Feb/23 11:55
• Updated: 27/Feb/23 06:37
• Resolved: 27/Feb/23 06:37

Description

As things stand, ContainerManagerImpl holds a reference to ContainerReplicaPendingOps. As new replicas are received or deleted from the DNs, the replicas are updated in ContainerStateManager under a lock, and then pending ops is updated. This leave the possibility of a race condition where the replicas have been updated but pending ops has not.

To avoid this, we should move the pendingOps update into the StateManager so it is updated along with the replicas under the same lock.

Issue Links

• links to: GitHub Pull Request #4298