Uploaded image for project: 'Apache Ozone'
  1. Apache Ozone
  2. HDDS-795

RocksDb specific classes leak from DBStore/Table interfaces

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • None
    • None
    • None

    Description

      org.apache.hadoop.utils.db.RocksDB and Table interfaces provide a vendor-independent way to access any key value store.

      The default implementation uses RocksDb but other implementation also could be used (for example an InMemory implementation for testing only).

      The current Table interface contains methods which depend on RocksDB specific classes. For example:

      public interface DBStore extends AutoCloseable {
      //...
      /**
         * Return the Column Family handle. TODO: This leaks an RockDB abstraction
         * into Ozone code, cleanup later.
         *
         * @return ColumnFamilyHandle
         */
        ColumnFamilyHandle getHandle();
      //...
      

      We need to remove the RocksDB specific classes from the generic interfaces.

      Attachments

        1. HDDS-795.001.patch
          28 kB
          Marton Elek
        2. HDDS-795.002.patch
          29 kB
          Marton Elek
        3. HDDS-795.003.patch
          29 kB
          Marton Elek
        4. HDDS-795.004.patch
          28 kB
          Marton Elek
        5. HDDS-795.005.patch
          29 kB
          Marton Elek
        6. HDDS-795.006.patch
          29 kB
          Marton Elek
        7. HDDS-795.007.patch
          29 kB
          Marton Elek

        Issue Links

          Activity

            People

              elek Marton Elek
              elek Marton Elek
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: