[HDDS-7748] Rename OMFileRequest.addToOpenFileTable() to avoid misuse

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Component/s: OM
• Labels: pull-request-available
• Assignee: Tsz-wo Sze
• Reporter: Wei-Chiu Chuang
• Created: 07/Jan/23 22:43
• Updated: 19/Jan/23 20:48
• Resolved: 19/Jan/23 20:47

Description

This is a badly named API.

OMFileRequest.addToOpenFileTable() is specifically designed for S3 multipart upload,

/**
 * Adding multipart omKeyInfo to open file table.
 *
 *@paramomMetadataMgrOM Metadata Manager
 *@parambatchOpbatch of db operations
 *@paramomFileInfoomKeyInfo
 *@paramuploadIDuploadID
 *@returnmultipartFileKey
 *@throwsIOException DB failure
 */
public static String addToOpenFileTable(OMMetadataManager omMetadataMgr,
    BatchOperation batchOp, OmKeyInfo omFileInfo, String uploadID,
    long volumeId, long bucketId) throws IOException {

Adding to open file table for non-multipart upload and multipart upload are different. Please rename this API to avoid misuse in the future.

Issue Links

• links to: GitHub Pull Request #4176