[HDDS-7259] Fix uncounted blocksDeleted in BlockDeletingService

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Labels: pull-request-available
• Assignee: Xu Shao Hong
• Reporter: Xu Shao Hong
• Created: 26/Sep/22 09:41
• Updated: 27/Jun/23 17:11
• Resolved: 08/Oct/22 12:11

Description

If the block info is null, then blocksDeleted is not increased and the numPendingDeletionBlocks then will not be decreased.

During ```chooseContainerForBlockDeletion```, all containers with such inexistent blocks will still be chosen, and normal block deletion will be blocked.

 

TODO:

Besides this, if deletion of certain block retries exceeds a certain number of times, the service should skip deleting it, otherwise invalid numPendingDeletionBlocks could accumulate beyond the limit and the following deletion will also stop. We should add this as a protection mechianism

Issue Links

• is related to: HDDS-7156 Clean container's inconsistent pendingDeletingBlockCount
• links to: GitHub Pull Request #3779