[HDDS-7147] DirectoryDeletingService interval unit mismatch

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Labels: pull-request-available
• Assignee: Aswin Shakil
• Reporter: Aswin Shakil
• Created: 18/Aug/22 23:33
• Updated: 16/Feb/23 14:38
• Resolved: 19/Aug/22 13:26

Description

DirectoryDeletingService is supposed to run every 60s by default for FSO buckets. Due to a wrong conversion, Instead of 60s it runs every 60000s~=16hours.

if (dirDeletingService == null) {
      long dirDeleteInterval = configuration.getTimeDuration(
          OZONE_DIR_DELETING_SERVICE_INTERVAL,
          OZONE_DIR_DELETING_SERVICE_INTERVAL_DEFAULT,
          TimeUnit.MILLISECONDS); ---> 60s converted to 60000
      long serviceTimeout = configuration.getTimeDuration(
          OZONE_BLOCK_DELETING_SERVICE_TIMEOUT,
          OZONE_BLOCK_DELETING_SERVICE_TIMEOUT_DEFAULT,
          TimeUnit.MILLISECONDS);
      dirDeletingService = new DirectoryDeletingService(dirDeleteInterval,
          TimeUnit.SECONDS, serviceTimeout, ozoneManager, configuration); ---> which is passed to the service in seconds.
      dirDeletingService.start();
    }

Issue Links

• relates to: HDDS-7328 Improve Deletion of FSO Paths
• links to: GitHub Pull Request #3695