[HDDS-6970] EC: Ensure DatanodeAdminMonitor can handle EC containers during decommission

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Implemented
• Fix Version/s: 1.3.0
• Labels: pull-request-available
• Assignee: Attila Doroszlai
• Reporter: Stephen O'Donnell
• Created: 29/Jun/22 09:09
• Updated: 01/Jul/22 17:38
• Resolved: 01/Jul/22 17:38

Description

In DatanodeAdminMonitorImpl.checkContainersReplicatedOnNode(), there is a call to get the ContainerReplicaCount for each container on the node:

 ContainerReplicaCount replicaSet =
            replicationManager.getContainerReplicaCount(cid);
        if (replicaSet.isSufficientlyReplicated()) {
          sufficientlyReplicated++;
        } else {
          if (LOG.isDebugEnabled()) {

From here, it calls isSufficientlyReplicated to decide if the replica has enough copies elsewhere to let this node continue decommissioning.

With the introduction of EC, we also have the ECContainerReplicaCounts object, but the class is not related to ContainerReplicaCount.

We need the ReplicationManager to create a ContainerReplicaCount or ECContainerReplica count object depending on the container type.

We probably also need to have an interface that replicationManager.getContainerReplicaCount returns providing the isSufficientlyReplicated and getReplicas() methods.

Note that right now, ECContainerReplicaCount.isSufficientlyReplicated takes a boolean flag, while ContainerReplicaCount.isSufficientlyReplicated does not. Rather than attempting to change the latter, perhaps we need to overload isSufficientlyReplicated in ECContainerReplicaCount to have no parameter and always pass false into the other method, which is what the decommission calls need.

Issue Links

• links to: GitHub Pull Request #3573