[HDDS-6739] Clean up MiniOzoneCluster config handling

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Implemented
• Fix Version/s: 1.5.0
• Component/s: test
• Epic Link: code-cleanup
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 12/May/22 10:46
• Updated: 10/May/24 08:13
• Resolved: 10/May/24 08:13

Description

MiniOzoneCluster builders have several methods to set various config properties. Some are complex and interrelated, others are just for convenience. We should not clutter it with setter method for each config property. We can set defaults for integration tests in hadoop-ozone/integration-test/src/test/resources/ozone-site.xml and override in specific tests where necessary. The goal of this task is to remove all trivial config setting methods.

Example:

https://github.com/apache/ozone/blob/5459b49538f16256a4e0f7d3c7f2981d0d7a9fae/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneCluster.java#L458-L466

    /**
     * Sets the total number of pipelines to create.
     * @param val number of pipelines
     * @return MiniOzoneCluster.Builder
     */
    public Builder setTotalPipelineNumLimit(int val) {
      pipelineNumLimit = val;
      return this;
    }

and its usage:

https://github.com/apache/ozone/blob/5459b49538f16256a4e0f7d3c7f2981d0d7a9fae/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneClusterImpl.java#L686-L689

      // MiniOzoneCluster should have global pipeline upper limit.
      conf.setInt(ScmConfigKeys.OZONE_SCM_RATIS_PIPELINE_LIMIT,
          pipelineNumLimit >= DEFAULT_PIPELINE_LIMIT ?
              pipelineNumLimit : DEFAULT_PIPELINE_LIMIT);

Issue Links

• is required by: HDDS-6713 Avoid the need to cast to MiniOzoneHAClusterImpl

Sub-Tasks

• Remove unused MiniOzoneCluster.Builder properties: Resolved
• Extract configurator for size settings from MiniOzoneCluster: Resolved
• Set simple properties in MiniOzoneCluster via Configuration: Resolved
• Introduce factory to configure MiniOzoneCluster's datanodes: Resolved
• Reduce code duplication in MiniOzoneCluster builders: Resolved
• Remove duplicate HA MiniOzoneCluster factory method: Resolved
• Move HA-specific settings to MiniOzoneHAClusterImpl.Builder: Resolved
• Remove setConf from MiniOzoneCluster public interface: Resolved
• Create new cluster ID and config instance in build(): Resolved