[HDDS-6439] Minor perf optimization in the version enums

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Labels: pull-request-available
• Assignee: Attila Doroszlai
• Reporter: István Fajth
• Created: 11/Mar/22 18:03
• Updated: 29/Nov/23 19:39
• Resolved: 15/Mar/22 18:27

Description

To avoid using values() all the time when the version is read from proto a minor optimization was suggested in HDDS-6391, this JIRA is to track this.

The suggestion:

  private static final Map<Integer, DatanodeVersion> BY_PROTO_VALUE =
      Arrays.stream(DatanodeVersion.values())
        .collect(toMap(DatanodeVersion::toProtoValue, identity()));

  public static DatanodeVersion fromProtoValue(int value) {
    return BY_PROTO_VALUE.getOrDefault(value, FUTURE_VERSION);
  }

Issue Links

• links to: GitHub Pull Request #3189