[HDDS-6426] OM keyTable and fileTable use different key formats.

• Type: Sub-task
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Component/s: OM
• Labels: pull-request-available
• Assignee: Jyotinder Singh
• Reporter: Ethan Rose
• Created: 07/Mar/22 21:27
• Updated: 08/Aug/22 16:15

Description

HDDS-5835 changed OMMetadataManager#getKeyTable to return a different table based on the bucket layout: fileTable for FSO buckets, keyTable otherwise. The problem is that these two tables have completely different sets of keys and key formats. It is not enough to change existing requests expecting to operate on the key table to now point to the file table if they are invoked on an FSO bucket, because they will query the table with the wrong key format.

This implementation is misleading for developers (you ask for a keyTable and might get a fileTable instead) and caused HDDS-6414, while possibly masking other similar bugs for existing requests. This Jira is to consider a less error-prone approach.

Issue Links

• causes: HDDS-6414 Ozone doesn’t reclaim space after deletion of volume via ofs
• is caused by: HDDS-5835 Follow up task to use bucket layout specific DB table in OmMetadataManager.getKeyTable() - part2
• relates to: HDDS-6479 [FSO] KeyRenameRequestWithFSO fails with "org.apache.hadoop.ozone.om.exceptions.OMException: Unable to get file status"
• links to: GitHub Pull Request #3251