[HDDS-6424] KeyInputStream should create BlockStreams lazily - ASF JIRA

Log work

Agile Board

Rank to Top

Rank to Bottom

Attach files

Attach Screenshot

Bulk Copy Attachments

Bulk Move Attachments

Add vote

Voters

Watch issue

Watchers

Create sub-task

Convert to sub-task

Link

Clone

Labels

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Open
Priority: Major
Resolution: Unresolved
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
None

Description

In KeyInputStream, when the object is initialized, it pre-creates a BlockInputStream for every block in the Key. If the key is very large, this can be a lot of streams. For the Ratis read case, the BlockInputStream objects are lightweight and they don't setup the block read until they are read for the first time. However this is not the case with the EC readers, which allocate buffers and some resources when they are allocated.

Additionally, when the KeyInputStream has read past a given block it does not close the previous stream. So even if the EC readers delayed allocation until first read, the resources will not be freed by close until after the Key has been read completely.

We should make KeyInputStream open the Block stream on demand, and close it after its read position has moved outside the current block (either by seek or normal reads).