[HDDS-6400] EC: Refactor ECKeyOutputStream for better code reuse

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Labels: pull-request-available
• Assignee: Kaijie Chen
• Reporter: Kaijie Chen
• Created: 02/Mar/22 08:53
• Updated: 11/May/22 01:21
• Resolved: 10/May/22 22:50

Description

Refactor ECKeyOutputStream to make the code cleaner.

Reuse code when writing the last stripe or rewriting failed stripes.

The changes includes:

1. handleDataWrite() has been changed to handleWrite(),
   it will check strip full and call encodeAndWriteParityCells().
2. checkAndWriteParityCells() has been changed to encodeAndWriteParityCells(),
   and it can be reused to encode partial stripe in close().
3. handleParityWrites() has seperated generateParityCells(),
   it can be reused in rewriteStripeToNewBlockGroup().
4. handleFailedStreams() has been changed to excludePipelineAndFailedDN(),
   it will exclude both failed pipeline and failed datanodes.
5. Reuse handleOutputStreamWrite() in close().
6. generateParityCells() will remove padding from dataBuffers after encoding,
   so we don't have to track stripe length in rewrite.
7. Moved isLastBlock check inside handleParityWrites(),
   so that we don't need to pass isClose parameter around in rewrite.

Issue Links

• is duplicated by: HDDS-6475 EC: [Refactor-2] Check and write parity cells inside handleDataWrite
• links to: GitHub Pull Request #3151
• links to: GitHub Pull Request #3372