Details
-
Sub-task
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
-
None
Description
By reading through the doc ErasureCoding.md, I found 2 configs for cluster-level EC:
<property> <name>ozone.server.default.replication.type</name> <value>EC</value> </property> <property> <name>ozone.server.default.replication</name> <value>RS-6-3-1024k</value> </property>
But by referring to the latest code of HDDS-3816-ec, the enums defined are never referenced
public static final String OZONE_SERVER_DEFAULT_REPLICATION_KEY = "ozone.server.default.replication"; public static final String OZONE_SERVER_DEFAULT_REPLICATION_DEFAULT = ReplicationFactor.THREE.toString(); public static final String OZONE_SERVER_DEFAULT_REPLICATION_TYPE_KEY = "ozone.server.default.replication.type"; public static final String OZONE_SERVER_DEFAULT_REPLICATION_TYPE_DEFAULT = ReplicationType.RATIS.toString();
IMO, the 2 configs should be checked in OzoneConfigUtil#resolveReplicationConfigPreference() as a fallback if no bucket-level policy is specified,
orĀ we could make the change in OzoneManager#getDefaultReplicationConfig() which now refer to "ozone.replication" and "ozone.replication.type".
Attachments
Issue Links
- links to