[HDDS-6166] BlockInputStream unbuffer() should be synchronized

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.1.0
• Component/s: Ozone Client
• Assignee: Unassigned
• Reporter: Wei-Chiu Chuang
• Created: 10/Jan/22 05:07
• Updated: 10/Jan/22 08:09
• Resolved: 10/Jan/22 08:09

Description

@Override
public void unbuffer() {
  storePosition();
  releaseClient();

  final List<ChunkInputStream> inputStreams = this.chunkStreams;
  if (inputStreams != null) {
    for (ChunkInputStream is : inputStreams) {
      is.unbuffer();
    }
  }
} 

I believe the unbuffer() should be made synchronized to avoid potential data race in the future.

Example: S3AInputStream https://github.com/apache/hadoop/blob/c7ec1897c408257ea1f157123c0d1604b632c048/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java#L878-L889

cc: adoroszlai

Issue Links

• Is contained by: HDDS-6157 More consistent synchronization in InputStreams