[HDDS-5671] ContainerBalancer#stop should prevent the current balancing thread from interrupting itself.

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Component/s: SCM
• Labels: pull-request-available
• Target Version/s: 1.2.0
• Assignee: Siddhant Sangwan
• Reporter: Siddhant Sangwan
• Created: 25/Aug/21 16:55
• Updated: 05/May/23 15:22
• Resolved: 29/Nov/21 04:07

Description

If the current thread calls the ContainerBalancer#stop method, it ends up calling interrupt and join on itself.

ContainerBalancer#stop

balancerRunning = false;
currentBalancingThread.interrupt();
currentBalancingThread.join(1000);

This causes:

[ContainerBalancer] WARN balancer.ContainerBalancer (ContainerBalancer.java:stop(731)) - Interrupted while waiting for balancing thread to join.
[ContainerBalancer] INFO balancer.ContainerBalancer (ContainerBalancer.java:stop(736)) - Container Balancer stopped successfully.

The current thread should be prevented from interrupting itself. The interrupt and join calls are required when ContainerBalancer#stop has been called from a different thread and balancer needs to stop gracefully.

Issue Links

• fixes: HDDS-5760 ContainerBalancer incorrectly exits an iteration early without checking move results.
• links to: GitHub Pull Request #2578