[HDDS-5650] Wrong mock assumption in TestOmMetrics#testBucketOps

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Sprint: HDDS BadLands
• Assignee: Aswin Shakil
• Reporter: Uma Maheswara Rao G
• Created: 20/Aug/21 17:27
• Updated: 12/Oct/22 23:00
• Resolved: 12/Oct/22 23:00

Description

I noticed a mock in this test as follows:

Mockito.doReturn(null).when(mockBm).getBucketInfo(null, null);

But in reality the behavior would be different as per the source code:

@Override
public OmBucketInfo getBucketInfo(String volumeName, String bucketName)
 throws IOException {
 Preconditions.checkNotNull(volumeName);
 Preconditions.checkNotNull(bucketName);

 

Due to the above preconditions, null is not allowed and it will throw NPE.

Some one who familiar with this code can confirm why we added this differed mock behavior.