[HDDS-5303] OzoneDelegationTokenSecretManager breaks the interface contract of S3SecretManager

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Assignee: Marton Elek
• Reporter: Marton Elek
• Created: 04/Jun/21 10:39
• Updated: 20/Nov/23 14:55
• Resolved: 20/Nov/23 13:37

Description

S3SecretManager is a generic interface which supposed to return with the secret key for one specific AWS access key id.

It's a generic interface which may have multiple implementation.

Unfortunately, it's not possible to use any implementation as OzoneDelegationTokenSecretManager does an explicit cast to retrieve the MetadataManager.

Instead of breaking the abstract contract of interface it seems to be better to directly inject the required MetadataManager to the OzoneDelegationTokenSecretManager which makes it possible to use an implementation.

Issue Links

• is fixed by: HDDS-7815 Extract layer of S3 secret manipulation