[HDDS-5256] Fix fall back of config in SCM HA Cluster

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Component/s: SCM HA
• Labels: pull-request-available
• Assignee: Bharat Viswanadham
• Reporter: Bharat Viswanadham
• Created: 20/May/21 07:25
• Updated: 21/May/21 03:59
• Resolved: 21/May/21 03:59

Description

If config is appended with serviceId and nodeId use that, else fall back to config appended without service id and node id. If that is also not defined, fallback to a default value.

Example:
ozone.scm.grpc.port = 9898 is set

We should use this port for SCM Grpc Service, as there is no port config with serviceid and nodeid defined.

Current code behavior is if port config with service id and node id not defined read from the default value.

The problematic code is

        String ratisPortKey = ConfUtils.addKeySuffixes(OZONE_SCM_RATIS_PORT_KEY,
            serviceId, nodeId);
int ratisPort = conf.getInt(ratisPortKey, OZONE_SCM_RATIS_PORT_DEFAULT);

In this way fix similarly for all RPC services.

Issue Links

• links to: GitHub Pull Request #2272