[HDDS-501] AllocateBlockResponse.keyLocation must be an optional field

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 0.2.1
• Assignee: Arpit Agarwal
• Reporter: Arpit Agarwal
• Created: 18/Sep/18 21:23
• Updated: 12/Nov/18 11:10
• Resolved: 18/Sep/18 22:43

Description

keyLocation may not be initialized if allocateBlock fails in the following function:

public AllocateBlockResponse allocateBlock(RpcController controller,
    AllocateBlockRequest request) throws ServiceException {
  AllocateBlockResponse.Builder resp =
      AllocateBlockResponse.newBuilder();
  try {
    KeyArgs keyArgs = request.getKeyArgs();
    OmKeyArgs omKeyArgs = new OmKeyArgs.Builder()
        .setVolumeName(keyArgs.getVolumeName())
        .setBucketName(keyArgs.getBucketName())
        .setKeyName(keyArgs.getKeyName())
        .build();
    OmKeyLocationInfo newLocation = impl.allocateBlock(omKeyArgs,
        request.getClientID());
    resp.setKeyLocation(newLocation.getProtobuf());
    resp.setStatus(Status.OK);
  } catch (IOException e) {
    resp.setStatus(exceptionToResponseStatus(e));
  }
  return resp.build();
}

Hence it must be an optional field. Else the protobuf builder exception suppresses the real issue.