[HDDS-4669] TestOzoneFileSystem#testTrash() fails when OM Ratis is enabled

• Type: Sub-task
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Labels: pull-request-available
• Target Version/s: 1.1.0
• Assignee: Sadanand Shenoy
• Reporter: Hanisha Koneru
• Created: 11/Jan/21 20:59
• Updated: 22/Jan/21 06:15
• Resolved: 21/Jan/21 11:48

Description

TestOzoneFileSystem#testTrash() is failing when OM Ratis is enabled. This is happening because of the following error:

2021-01-11 11:02:25,451 [pool-29-thread-1] INFO  om.TrashPolicyOzone (TrashPolicyOzone.java:lambda$run$0(181)) - Unable to checkpoint
java.lang.IllegalArgumentException
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:128)
	at org.apache.hadoop.ozone.om.ratis.OzoneManagerRatisServer.createWriteRaftClientRequest(OzoneManagerRatisServer.java:149)
	at org.apache.hadoop.ozone.om.ratis.OzoneManagerRatisServer.submitRequest(OzoneManagerRatisServer.java:113)
	at org.apache.hadoop.ozone.protocolPB.OzoneManagerProtocolServerSideTranslatorPB.submitRequestToRatis(OzoneManagerProtocolServerSideTranslatorPB.java:182)
	at org.apache.hadoop.ozone.protocolPB.OzoneManagerProtocolServerSideTranslatorPB.processRequest(OzoneManagerProtocolServerSideTranslatorPB.java:144)
	at org.apache.hadoop.hdds.server.OzoneProtocolMessageDispatcher.processRequest(OzoneProtocolMessageDispatcher.java:87)
	at org.apache.hadoop.ozone.protocolPB.OzoneManagerProtocolServerSideTranslatorPB.submitRequest(OzoneManagerProtocolServerSideTranslatorPB.java:122)
	at org.apache.hadoop.ozone.om.TrashOzoneFileSystem$RenameIterator.processKeyPath(TrashOzoneFileSystem.java:354)
	at org.apache.hadoop.ozone.om.TrashOzoneFileSystem$OzoneListingIterator.iterate(TrashOzoneFileSystem.java:314)

	at org.apache.hadoop.ozone.om.TrashOzoneFileSystem.rename(TrashOzoneFileSystem.java:124)Disconnected from the target VM, address: '127.0.0.1:57683', transport: 'socket'
	at org.apache.hadoop.ozone.om.TrashPolicyOzone.createCheckpoint(TrashPolicyOzone.java:230)
	at org.apache.hadoop.ozone.om.TrashPolicyOzone.access$1000(TrashPolicyOzone.java:55)
	at org.apache.hadoop.ozone.om.TrashPolicyOzone$Emptier.lambda$run$0(TrashPolicyOzone.java:178)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:266)
	at java.util.concurrent.FutureTask.run(FutureTask.java)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)

The Filesystem which is calling the rename is using the DUMMY_CLIENT_ID and hence the Precondition fails in OzoneManagerRatisServer.createWriteRaftClientRequest. 
To reproduce, set ozone.om.ratis.enable to true in TestOzoneFileSystem#setupOzoneFileSystem.

Issue Links

• is caused by: HDDS-4387 Create a Trash File System that will be used by Trash Emptier
• links to: GitHub Pull Request #1818