Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.2.1
    • test
    • None

    Description

      testBlockWriteViaRatis and testMultiBlockWrites2 fail with NPE and AssertionError respectively.

      [INFO] Running org.apache.hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
      [ERROR] Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 21.352 s <<< FAILURE! - in org.apache.hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
      [ERROR] testBlockWriteViaRatis(org.apache.hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient) Time elapsed: 1.235 s <<< ERROR!
      java.lang.NullPointerException
      at org.apache.hadoop.hdds.scm.XceiverClientRatis.sendCommand(XceiverClientRatis.java:211)
      at org.apache.hadoop.hdds.scm.storage.ContainerProtocolCalls.createContainer(ContainerProtocolCalls.java:297)
      at org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.checkKeyLocationInfo(ChunkGroupOutputStream.java:197)
      at org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.allocateNewBlock(ChunkGroupOutputStream.java:476)
      at org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.handleWrite(ChunkGroupOutputStream.java:271)
      at org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.write(ChunkGroupOutputStream.java:250)
      at org.apache.hadoop.ozone.client.io.OzoneOutputStream.write(OzoneOutputStream.java:47)
      at java.io.OutputStream.write(OutputStream.java:75)
      at org.apache.hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient.testBlockWriteViaRatis(TestCloseContainerHandlingByClient.java:403)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at java.lang.reflect.Method.invoke(Method.java:498)
      at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
      at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
      at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
      at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
      at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
      at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
      at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
      at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
      at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
      at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
      at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
      at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
      at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
      at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
      at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
      at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
      at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
      at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
      at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
      at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:379)
      at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:340)
      at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:125)
      at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:413)

      Attachments

        1. HDDS-464.004.patch
          11 kB
          Lokesh Jain
        2. HDDS-464.003.patch
          11 kB
          Lokesh Jain
        3. HDDS-464.002.patch
          8 kB
          Lokesh Jain
        4. HDDS-464.001.patch
          7 kB
          Lokesh Jain

        Issue Links

          Activity

            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 22s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            0 mvndep 2m 0s Maven dependency ordering for branch
            +1 mvninstall 20m 10s trunk passed
            +1 compile 15m 37s trunk passed
            +1 checkstyle 2m 52s trunk passed
            +1 mvnsite 1m 6s trunk passed
            +1 shadedclient 14m 12s branch has no errors when building and testing our client artifacts.
            0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-ozone/integration-test
            +1 findbugs 1m 4s trunk passed
            +1 javadoc 1m 23s trunk passed
                  Patch Compile Tests
            0 mvndep 0m 23s Maven dependency ordering for patch
            +1 mvninstall 1m 0s the patch passed
            +1 compile 15m 14s the patch passed
            +1 javac 15m 14s the patch passed
            -0 checkstyle 2m 59s root: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
            +1 mvnsite 1m 13s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 xml 0m 1s The patch has no ill-formed XML file.
            +1 shadedclient 9m 46s patch has no errors when building and testing our client artifacts.
            0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-ozone/integration-test
            +1 findbugs 1m 14s the patch passed
            +1 javadoc 1m 14s the patch passed
                  Other Tests
            +1 unit 1m 12s common in the patch passed.
            -1 unit 10m 41s integration-test in the patch failed.
            -1 asflicense 0m 36s The patch generated 1 ASF License warnings.
            102m 59s



            Reason Tests
            Failed junit tests hadoop.ozone.freon.TestRandomKeyGenerator
              hadoop.ozone.freon.TestDataValidate
              hadoop.ozone.client.rpc.TestOzoneRpcClient
              hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
              hadoop.ozone.client.rest.TestOzoneRestClient



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1
            JIRA Issue HDDS-464
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12939825/HDDS-464.001.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
            uname Linux 14d75bf0129a 4.4.0-133-generic #159-Ubuntu SMP Fri Aug 10 07:31:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / b95aa56
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_181
            findbugs v3.1.0-RC1
            checkstyle https://builds.apache.org/job/PreCommit-HDDS-Build/1086/artifact/out/diff-checkstyle-root.txt
            unit https://builds.apache.org/job/PreCommit-HDDS-Build/1086/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
            Test Results https://builds.apache.org/job/PreCommit-HDDS-Build/1086/testReport/
            asflicense https://builds.apache.org/job/PreCommit-HDDS-Build/1086/artifact/out/patch-asflicense-problems.txt
            Max. process+thread count 2867 (vs. ulimit of 10000)
            modules C: hadoop-hdds/common hadoop-ozone/integration-test U: .
            Console output https://builds.apache.org/job/PreCommit-HDDS-Build/1086/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 2m 0s Maven dependency ordering for branch +1 mvninstall 20m 10s trunk passed +1 compile 15m 37s trunk passed +1 checkstyle 2m 52s trunk passed +1 mvnsite 1m 6s trunk passed +1 shadedclient 14m 12s branch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-ozone/integration-test +1 findbugs 1m 4s trunk passed +1 javadoc 1m 23s trunk passed       Patch Compile Tests 0 mvndep 0m 23s Maven dependency ordering for patch +1 mvninstall 1m 0s the patch passed +1 compile 15m 14s the patch passed +1 javac 15m 14s the patch passed -0 checkstyle 2m 59s root: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 mvnsite 1m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 shadedclient 9m 46s patch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-ozone/integration-test +1 findbugs 1m 14s the patch passed +1 javadoc 1m 14s the patch passed       Other Tests +1 unit 1m 12s common in the patch passed. -1 unit 10m 41s integration-test in the patch failed. -1 asflicense 0m 36s The patch generated 1 ASF License warnings. 102m 59s Reason Tests Failed junit tests hadoop.ozone.freon.TestRandomKeyGenerator   hadoop.ozone.freon.TestDataValidate   hadoop.ozone.client.rpc.TestOzoneRpcClient   hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient   hadoop.ozone.client.rest.TestOzoneRestClient Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 JIRA Issue HDDS-464 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12939825/HDDS-464.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml uname Linux 14d75bf0129a 4.4.0-133-generic #159-Ubuntu SMP Fri Aug 10 07:31:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / b95aa56 maven version: Apache Maven 3.3.9 Default Java 1.8.0_181 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDDS-Build/1086/artifact/out/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDDS-Build/1086/artifact/out/patch-unit-hadoop-ozone_integration-test.txt Test Results https://builds.apache.org/job/PreCommit-HDDS-Build/1086/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDDS-Build/1086/artifact/out/patch-asflicense-problems.txt Max. process+thread count 2867 (vs. ulimit of 10000) modules C: hadoop-hdds/common hadoop-ozone/integration-test U: . Console output https://builds.apache.org/job/PreCommit-HDDS-Build/1086/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 15s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            0 mvndep 2m 12s Maven dependency ordering for branch
            +1 mvninstall 21m 40s trunk passed
            +1 compile 16m 2s trunk passed
            +1 checkstyle 3m 27s trunk passed
            +1 mvnsite 1m 57s trunk passed
            +1 shadedclient 17m 11s branch has no errors when building and testing our client artifacts.
            0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-ozone/integration-test
            +1 findbugs 1m 57s trunk passed
            +1 javadoc 2m 3s trunk passed
                  Patch Compile Tests
            0 mvndep 0m 20s Maven dependency ordering for patch
            +1 mvninstall 1m 29s the patch passed
            +1 compile 15m 29s the patch passed
            +1 javac 15m 29s the patch passed
            -0 checkstyle 3m 25s root: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
            +1 mvnsite 1m 56s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 xml 0m 2s The patch has no ill-formed XML file.
            +1 shadedclient 11m 10s patch has no errors when building and testing our client artifacts.
            0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-ozone/integration-test
            +1 findbugs 2m 10s the patch passed
            +1 javadoc 2m 5s the patch passed
                  Other Tests
            +1 unit 1m 7s common in the patch passed.
            +1 unit 0m 48s container-service in the patch passed.
            -1 unit 4m 34s integration-test in the patch failed.
            -1 asflicense 0m 40s The patch generated 1 ASF License warnings.
            109m 32s



            Reason Tests
            Failed junit tests hadoop.hdds.scm.pipeline.TestNodeFailure
              hadoop.ozone.freon.TestDataValidate



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1
            JIRA Issue HDDS-464
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12939830/HDDS-464.002.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
            uname Linux 602e85185a4a 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / a65c3ea
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_181
            findbugs v3.1.0-RC1
            checkstyle https://builds.apache.org/job/PreCommit-HDDS-Build/1087/artifact/out/diff-checkstyle-root.txt
            unit https://builds.apache.org/job/PreCommit-HDDS-Build/1087/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
            Test Results https://builds.apache.org/job/PreCommit-HDDS-Build/1087/testReport/
            asflicense https://builds.apache.org/job/PreCommit-HDDS-Build/1087/artifact/out/patch-asflicense-problems.txt
            Max. process+thread count 2150 (vs. ulimit of 10000)
            modules C: hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone/integration-test U: .
            Console output https://builds.apache.org/job/PreCommit-HDDS-Build/1087/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 2m 12s Maven dependency ordering for branch +1 mvninstall 21m 40s trunk passed +1 compile 16m 2s trunk passed +1 checkstyle 3m 27s trunk passed +1 mvnsite 1m 57s trunk passed +1 shadedclient 17m 11s branch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-ozone/integration-test +1 findbugs 1m 57s trunk passed +1 javadoc 2m 3s trunk passed       Patch Compile Tests 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvninstall 1m 29s the patch passed +1 compile 15m 29s the patch passed +1 javac 15m 29s the patch passed -0 checkstyle 3m 25s root: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) +1 mvnsite 1m 56s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 shadedclient 11m 10s patch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-ozone/integration-test +1 findbugs 2m 10s the patch passed +1 javadoc 2m 5s the patch passed       Other Tests +1 unit 1m 7s common in the patch passed. +1 unit 0m 48s container-service in the patch passed. -1 unit 4m 34s integration-test in the patch failed. -1 asflicense 0m 40s The patch generated 1 ASF License warnings. 109m 32s Reason Tests Failed junit tests hadoop.hdds.scm.pipeline.TestNodeFailure   hadoop.ozone.freon.TestDataValidate Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 JIRA Issue HDDS-464 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12939830/HDDS-464.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml uname Linux 602e85185a4a 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / a65c3ea maven version: Apache Maven 3.3.9 Default Java 1.8.0_181 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDDS-Build/1087/artifact/out/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDDS-Build/1087/artifact/out/patch-unit-hadoop-ozone_integration-test.txt Test Results https://builds.apache.org/job/PreCommit-HDDS-Build/1087/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDDS-Build/1087/artifact/out/patch-asflicense-problems.txt Max. process+thread count 2150 (vs. ulimit of 10000) modules C: hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone/integration-test U: . Console output https://builds.apache.org/job/PreCommit-HDDS-Build/1087/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
            ljain Lokesh Jain added a comment -

            shashikant Please take a look at the v3 patch.

            ljain Lokesh Jain added a comment - shashikant Please take a look at the v3 patch.
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 24s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            0 mvndep 2m 12s Maven dependency ordering for branch
            +1 mvninstall 22m 12s trunk passed
            +1 compile 18m 2s trunk passed
            +1 checkstyle 3m 35s trunk passed
            +1 mvnsite 2m 39s trunk passed
            +1 shadedclient 18m 31s branch has no errors when building and testing our client artifacts.
            0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-ozone/integration-test
            +1 findbugs 2m 41s trunk passed
            +1 javadoc 2m 34s trunk passed
                  Patch Compile Tests
            0 mvndep 0m 22s Maven dependency ordering for patch
            +1 mvninstall 1m 55s the patch passed
            +1 compile 22m 32s the patch passed
            +1 javac 22m 32s the patch passed
            -0 checkstyle 3m 58s root: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
            +1 mvnsite 3m 18s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 xml 0m 1s The patch has no ill-formed XML file.
            +1 shadedclient 13m 4s patch has no errors when building and testing our client artifacts.
            0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-ozone/integration-test
            +1 findbugs 3m 29s the patch passed
            +1 javadoc 2m 56s the patch passed
                  Other Tests
            +1 unit 1m 17s common in the patch passed.
            +1 unit 1m 6s container-service in the patch passed.
            +1 unit 0m 32s client in the patch passed.
            -1 unit 7m 45s integration-test in the patch failed.
            -1 asflicense 0m 49s The patch generated 1 ASF License warnings.
            132m 56s



            Reason Tests
            Failed junit tests hadoop.ozone.freon.TestDataValidate



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1
            JIRA Issue HDDS-464
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12939866/HDDS-464.003.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
            uname Linux a9f14966f33e 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / 82fbbd5
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_181
            findbugs v3.1.0-RC1
            checkstyle https://builds.apache.org/job/PreCommit-HDDS-Build/1089/artifact/out/diff-checkstyle-root.txt
            unit https://builds.apache.org/job/PreCommit-HDDS-Build/1089/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
            Test Results https://builds.apache.org/job/PreCommit-HDDS-Build/1089/testReport/
            asflicense https://builds.apache.org/job/PreCommit-HDDS-Build/1089/artifact/out/patch-asflicense-problems.txt
            Max. process+thread count 2220 (vs. ulimit of 10000)
            modules C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/client hadoop-ozone/integration-test U: .
            Console output https://builds.apache.org/job/PreCommit-HDDS-Build/1089/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 2m 12s Maven dependency ordering for branch +1 mvninstall 22m 12s trunk passed +1 compile 18m 2s trunk passed +1 checkstyle 3m 35s trunk passed +1 mvnsite 2m 39s trunk passed +1 shadedclient 18m 31s branch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-ozone/integration-test +1 findbugs 2m 41s trunk passed +1 javadoc 2m 34s trunk passed       Patch Compile Tests 0 mvndep 0m 22s Maven dependency ordering for patch +1 mvninstall 1m 55s the patch passed +1 compile 22m 32s the patch passed +1 javac 22m 32s the patch passed -0 checkstyle 3m 58s root: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 mvnsite 3m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 shadedclient 13m 4s patch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-ozone/integration-test +1 findbugs 3m 29s the patch passed +1 javadoc 2m 56s the patch passed       Other Tests +1 unit 1m 17s common in the patch passed. +1 unit 1m 6s container-service in the patch passed. +1 unit 0m 32s client in the patch passed. -1 unit 7m 45s integration-test in the patch failed. -1 asflicense 0m 49s The patch generated 1 ASF License warnings. 132m 56s Reason Tests Failed junit tests hadoop.ozone.freon.TestDataValidate Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 JIRA Issue HDDS-464 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12939866/HDDS-464.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml uname Linux a9f14966f33e 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 82fbbd5 maven version: Apache Maven 3.3.9 Default Java 1.8.0_181 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDDS-Build/1089/artifact/out/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDDS-Build/1089/artifact/out/patch-unit-hadoop-ozone_integration-test.txt Test Results https://builds.apache.org/job/PreCommit-HDDS-Build/1089/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDDS-Build/1089/artifact/out/patch-asflicense-problems.txt Max. process+thread count 2220 (vs. ulimit of 10000) modules C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/client hadoop-ozone/integration-test U: . Console output https://builds.apache.org/job/PreCommit-HDDS-Build/1089/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

            Thanks ljain, for the updated patch. The patch looks good to me. There are few checkstyle issues that need to be addressed.

            I have one minor comment other than this:

            XceiverClientRatis.java:211

            if (reply == null) {
              throw new IOException(
                  String.format("Could not execute the request %s", request));
            }
            

            I think we should throw a proper exception from Raft Client in case the client request can not be served and the reply is null. This needs changes in the Ratis code.

            I am +1 on the patch otherwsie.

            shashikant Shashikant Banerjee added a comment - Thanks ljain , for the updated patch. The patch looks good to me. There are few checkstyle issues that need to be addressed. I have one minor comment other than this: XceiverClientRatis.java:211 if (reply == null ) { throw new IOException( String .format( "Could not execute the request %s" , request)); } I think we should throw a proper exception from Raft Client in case the client request can not be served and the reply is null. This needs changes in the Ratis code. I am +1 on the patch otherwsie.
            ljain Lokesh Jain added a comment -

            shashikant Thanks for reviewing the patch! v4 patch addresses your comments.

            ljain Lokesh Jain added a comment - shashikant Thanks for reviewing the patch! v4 patch addresses your comments.
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 14s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            0 mvndep 2m 10s Maven dependency ordering for branch
            +1 mvninstall 21m 12s trunk passed
            +1 compile 20m 13s trunk passed
            +1 checkstyle 3m 39s trunk passed
            +1 mvnsite 2m 38s trunk passed
            +1 shadedclient 18m 21s branch has no errors when building and testing our client artifacts.
            0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-ozone/integration-test
            +1 findbugs 2m 41s trunk passed
            +1 javadoc 2m 30s trunk passed
                  Patch Compile Tests
            0 mvndep 0m 23s Maven dependency ordering for patch
            +1 mvninstall 2m 0s the patch passed
            +1 compile 16m 30s the patch passed
            +1 javac 16m 30s the patch passed
            -0 checkstyle 3m 38s root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
            +1 mvnsite 2m 37s the patch passed
            +1 whitespace 0m 1s The patch has no whitespace issues.
            +1 xml 0m 3s The patch has no ill-formed XML file.
            +1 shadedclient 11m 21s patch has no errors when building and testing our client artifacts.
            0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-ozone/integration-test
            +1 findbugs 3m 5s the patch passed
            +1 javadoc 2m 31s the patch passed
                  Other Tests
            +1 unit 1m 10s common in the patch passed.
            +1 unit 0m 52s container-service in the patch passed.
            +1 unit 0m 30s client in the patch passed.
            -1 unit 5m 4s integration-test in the patch failed.
            -1 asflicense 0m 42s The patch generated 1 ASF License warnings.
            120m 57s



            Reason Tests
            Failed junit tests hadoop.ozone.freon.TestDataValidate



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1
            JIRA Issue HDDS-464
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12940026/HDDS-464.004.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
            uname Linux 0ca775537d92 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / fdf5a3f
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_181
            findbugs v3.1.0-RC1
            checkstyle https://builds.apache.org/job/PreCommit-HDDS-Build/1110/artifact/out/diff-checkstyle-root.txt
            unit https://builds.apache.org/job/PreCommit-HDDS-Build/1110/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
            Test Results https://builds.apache.org/job/PreCommit-HDDS-Build/1110/testReport/
            asflicense https://builds.apache.org/job/PreCommit-HDDS-Build/1110/artifact/out/patch-asflicense-problems.txt
            Max. process+thread count 2503 (vs. ulimit of 10000)
            modules C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/client hadoop-ozone/integration-test U: .
            Console output https://builds.apache.org/job/PreCommit-HDDS-Build/1110/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 2m 10s Maven dependency ordering for branch +1 mvninstall 21m 12s trunk passed +1 compile 20m 13s trunk passed +1 checkstyle 3m 39s trunk passed +1 mvnsite 2m 38s trunk passed +1 shadedclient 18m 21s branch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-ozone/integration-test +1 findbugs 2m 41s trunk passed +1 javadoc 2m 30s trunk passed       Patch Compile Tests 0 mvndep 0m 23s Maven dependency ordering for patch +1 mvninstall 2m 0s the patch passed +1 compile 16m 30s the patch passed +1 javac 16m 30s the patch passed -0 checkstyle 3m 38s root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 mvnsite 2m 37s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 xml 0m 3s The patch has no ill-formed XML file. +1 shadedclient 11m 21s patch has no errors when building and testing our client artifacts. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-ozone/integration-test +1 findbugs 3m 5s the patch passed +1 javadoc 2m 31s the patch passed       Other Tests +1 unit 1m 10s common in the patch passed. +1 unit 0m 52s container-service in the patch passed. +1 unit 0m 30s client in the patch passed. -1 unit 5m 4s integration-test in the patch failed. -1 asflicense 0m 42s The patch generated 1 ASF License warnings. 120m 57s Reason Tests Failed junit tests hadoop.ozone.freon.TestDataValidate Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 JIRA Issue HDDS-464 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12940026/HDDS-464.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml uname Linux 0ca775537d92 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / fdf5a3f maven version: Apache Maven 3.3.9 Default Java 1.8.0_181 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDDS-Build/1110/artifact/out/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDDS-Build/1110/artifact/out/patch-unit-hadoop-ozone_integration-test.txt Test Results https://builds.apache.org/job/PreCommit-HDDS-Build/1110/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDDS-Build/1110/artifact/out/patch-asflicense-problems.txt Max. process+thread count 2503 (vs. ulimit of 10000) modules C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/client hadoop-ozone/integration-test U: . Console output https://builds.apache.org/job/PreCommit-HDDS-Build/1110/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
            shashikant Shashikant Banerjee added a comment - - edited

            The patch looks good to me. There are just 2 minor comments which can be taken care while committing as well.

            1) TestCloseContainerHandlingByClient:85 : Remove the comment as it is no more valid.

            2) One checkStyle issue got reported. That need to be addressed.

            I am +1 otherwise.

            shashikant Shashikant Banerjee added a comment - - edited The patch looks good to me. There are just 2 minor comments which can be taken care while committing as well. 1) TestCloseContainerHandlingByClient:85 : Remove the comment as it is no more valid. 2) One checkStyle issue got reported. That need to be addressed. I am +1 otherwise.
            aengineer Anu Engineer added a comment -

            shashikant Thanks for the reviews. +1, I will commit this now and clean up the issues while committing.

            aengineer Anu Engineer added a comment - shashikant Thanks for the reviews. +1, I will commit this now and clean up the issues while committing.
            aengineer Anu Engineer added a comment -

            shashikant Thanks for the reviews. ljainThanks for the contribution. I have committed to both trunk and ozone-2.0

            aengineer Anu Engineer added a comment - shashikant Thanks for the reviews. ljain Thanks for the contribution. I have committed to both trunk and ozone-2.0
            hudson Hudson added a comment -

            SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14996 (See https://builds.apache.org/job/Hadoop-trunk-Commit/14996/)
            HDDS-464. Fix TestCloseContainerHandlingByClient. Contributed by Lokesh (aengineer: rev f938925bde1d481bacb2546096a1e49fe796b411)

            • (edit) hadoop-hdds/common/src/main/resources/ozone-default.xml
            • (edit) hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestCloseContainerHandlingByClient.java
            • (edit) hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java
            • (edit) hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientRatis.java
            • (edit) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java
            • (edit) hadoop-hdds/common/src/main/java/org/apache/ratis/RatisHelper.java
            • (edit) hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
            hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14996 (See https://builds.apache.org/job/Hadoop-trunk-Commit/14996/ ) HDDS-464 . Fix TestCloseContainerHandlingByClient. Contributed by Lokesh (aengineer: rev f938925bde1d481bacb2546096a1e49fe796b411) (edit) hadoop-hdds/common/src/main/resources/ozone-default.xml (edit) hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestCloseContainerHandlingByClient.java (edit) hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java (edit) hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientRatis.java (edit) hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java (edit) hadoop-hdds/common/src/main/java/org/apache/ratis/RatisHelper.java (edit) hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java

            People

              ljain Lokesh Jain
              ljain Lokesh Jain
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: