[HDDS-4631] Fixed client set quota with 0

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.1.0
• Labels: pull-request-available
• Assignee: mingchao zhao
• Reporter: mingchao zhao
• Created: 30/Dec/20 07:18
• Updated: 18/Jan/21 04:49
• Resolved: 18/Jan/21 04:49

Description

Currently setting Quota is invalid if set to 0. It's actually going to be set to -1.

store.getVolume(volumeName).getBucket(bucketName).setQuota(
        OzoneQuota.parseQuota("0GB", 0));
    Assert.assertEquals(-1, bucket.getQuotaInBytes());
    Assert.assertEquals(-1, bucket.getQuotaInNamespace());

This behavior is actually incorrect, and In general setting quota to 0 isn't a valid entry even in HDFS. we can be consistent with HDFS on this part.：

java.lang.IllegalArgumentException: Invalid values for quota : 0

This problem occurs because the original client quota type is long. If the user does not specify quota, the default value for this field is 0.
A backend validation fails to verify that the user did not specify quota or set quoat to 0, since both actions are passed to the backend to be 0.
So it would be more appropriate to change the long to a string. If the user does not specify quota, it is null. It's easier to judge.

Issue Links

• links to: GitHub Pull Request #1746