[HDDS-4165] GitHub Actions cache does not work outside of workspace

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.1.0
• Component/s: build
• Labels: pull-request-available
• Target Version/s: 1.1.0
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 28/Aug/20 19:05
• Updated: 02/Sep/20 17:01
• Resolved: 02/Sep/20 14:05

Description

Ozone source is checked out for acceptance and kubernetes checks to /mnt, outside of GITHUB_WORKSPACE, and only after Cache steps. Therefore no files are found for which hash would be computed to be included in cache keys.

https://github.com/apache/hadoop-ozone/blob/44acf78aec6c3a4e1c5fea3a43971144c6da9a4c/.github/workflows/post-commit.yml#L167-L171

      - name: Cache for maven dependencies
        uses: actions/cache@v2
        with:
          path: ~/.m2/repository
          key: maven-repo-${{ hashFiles('**/pom.xml') }}

Cache key is always maven-repo-:

https://github.com/apache/hadoop-ozone/runs/1042358389#step:2:10

Cache restored from key: maven-repo-

The same old cache is used for all builds, even if dependencies are changed in pom.xml, gradually resulting in more and more downloads during builds:

https://github.com/apache/hadoop-ozone/runs/1036271227#step:9:680

[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/info/picocli/picocli/4.4.0/picocli-4.4.0.jar (389 kB at 2.4 MB/s)
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/ratis/ratis-server/1.0.0/ratis-server-1.0.0.jar (380 kB at 2.4 MB/s)
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/logging/log4j/log4j-api/2.13.3/log4j-api-2.13.3.jar (292 kB at 1.9 MB/s)
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/ratis/ratis-proto/1.0.0/ratis-proto-1.0.0.jar (1.2 MB at 6.6 MB/s)
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/logging/log4j/log4j-core/2.13.3/log4j-core-2.13.3.jar (1.7 MB at 8.5 MB/s)

Issue Links

• links to: GitHub Pull Request #1364