[HDDS-415] 'ozone om' with incorrect argument first logs all the STARTUP_MSG

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 0.2.1
• Target Version/s: 0.2.1
• Assignee: Namit Maheshwari
• Reporter: Namit Maheshwari
• Created: 07/Sep/18 19:59
• Updated: 12/Nov/18 11:10
• Resolved: 13/Sep/18 12:02

Description

 bin/ozone om with incorrect argument first logs all the STARTUP_MSG

➜ ozone-0.2.1-SNAPSHOT bin/ozone om -hgfj
2018-09-07 12:56:12,391 [main] INFO - STARTUP_MSG:
/************************************************************
STARTUP_MSG: Starting OzoneManager
STARTUP_MSG: host = HW11469.local/10.22.16.67
STARTUP_MSG: args = [-hgfj]
STARTUP_MSG: version = 3.2.0-SNAPSHOT
STARTUP_MSG: classpath = /private/tmp/ozone-0.2.1-SNAPSHOT/etc/hadoop:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jaxb-impl-2.2.3-1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/slf4j-log4j12-1.7.25.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/woodstox-core-5.0.3.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/curator-framework-2.12.0.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/curator-client-2.12.0.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/xz-1.0.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/htrace-core4-4.1.0-incubating.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/kerby-xdr-1.0.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/snappy-java-1.0.5.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jetty-servlet-9.3.19.v20170502.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/slf4j-api-1.7.25.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jackson-jaxrs-1.9.13.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/commons-logging-1.1.3.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/kerby-pkix-1.0.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/avro-1.7.7.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/zookeeper-3.4.9.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/javax.servlet-api-3.1.0.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jackson-annotations-2.9.5.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/kerb-server-1.0.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jetty-security-9.3.19.v20170502.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/log4j-1.2.17.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/commons-cli-1.2.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/protobuf-java-2.5.0.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jcip-annotations-1.0-1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/kerby-asn1-1.0.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/netty-3.10.5.Final.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jsr311-api-1.1.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jackson-xc-1.9.13.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/kerb-identity-1.0.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jetty-xml-9.3.19.v20170502.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/httpclient-4.5.2.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/kerby-config-1.0.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/guava-11.0.2.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/json-smart-2.3.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/kerb-util-1.0.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/commons-compress-1.4.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jetty-http-9.3.19.v20170502.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jersey-json-1.19.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jersey-servlet-1.19.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jaxb-api-2.2.11.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/commons-io-2.5.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/commons-configuration2-2.1.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jackson-core-asl-1.9.13.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/stax2-api-3.1.4.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/hadoop-annotations-3.2.0-SNAPSHOT.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jsp-api-2.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/kerb-crypto-1.0.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/commons-codec-1.11.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/asm-5.0.4.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/kerb-admin-1.0.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jetty-webapp-9.3.19.v20170502.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/paranamer-2.3.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/kerb-client-1.0.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/commons-collections-3.2.2.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jettison-1.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/token-provider-1.0.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jersey-core-1.19.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jsch-0.1.54.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/kerb-common-1.0.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/httpcore-4.4.4.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/commons-text-1.4.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/kerb-simplekdc-1.0.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jetty-util-9.3.19.v20170502.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jetty-server-9.3.19.v20170502.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jersey-server-1.19.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/accessors-smart-1.2.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/re2j-1.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/gson-2.2.4.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/hadoop-auth-3.2.0-SNAPSHOT.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/kerb-core-1.0.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/commons-net-3.6.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/commons-lang3-3.7.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/kerby-util-1.0.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jackson-mapper-asl-1.9.13.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/commons-math3-3.1.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/commons-beanutils-1.9.3.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/curator-recipes-2.12.0.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jetty-io-9.3.19.v20170502.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jsr305-3.0.0.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jackson-core-2.9.5.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/nimbus-jose-jwt-4.41.1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/lib/jackson-databind-2.9.5.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/hadoop-common-3.2.0-SNAPSHOT.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/common/hadoop-common-3.2.0-SNAPSHOT-tests.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdfs:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdfs/lib/okio-1.6.0.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdfs/lib/okhttp-2.7.5.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdfs/lib/jetty-util-ajax-9.3.19.v20170502.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdfs/lib/netty-all-4.0.52.Final.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdfs/lib/leveldbjni-all-1.8.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdfs/lib/commons-daemon-1.0.13.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdfs/hadoop-hdfs-client-3.2.0-SNAPSHOT.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdfs/hadoop-hdfs-client-3.2.0-SNAPSHOT-tests.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdfs/hadoop-hdfs-3.2.0-SNAPSHOT.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdfs/hadoop-hdfs-3.2.0-SNAPSHOT-tests.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/ozone:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/log4j-api-2.11.0.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/jmh-generator-annprocess-1.19.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/ratis-client-0.3.0-e6fd494-20180824.092754-1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/error_prone_annotations-2.2.0.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/sqlite-jdbc-3.8.7.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/aalto-xml-1.0.0.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/bcprov-jdk15on-1.54.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/ratis-grpc-0.3.0-e6fd494-20180824.092839-1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/bcpkix-jdk15on-1.54.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/log4j-core-2.11.0.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/javapoet-1.10.0.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/netty-tcnative-2.0.8.Final-osx-x86_64.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/auto-common-0.8.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/auto-service-1.0-rc4.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/jzlib-1.1.3.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/auto-value-1.6.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/auto-value-annotations-1.6.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/hamcrest-all-1.3.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/metrics-core-3.2.4.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/jctools-core-2.1.2.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/disruptor-3.4.2.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/ratis-server-0.3.0-e6fd494-20180824.092816-1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/ratis-netty-0.3.0-e6fd494-20180824.092902-1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/snakeyaml-1.8.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/j2objc-annotations-1.3.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/compress-lzf-1.0.3.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/rocksdbjni-5.14.2.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/animal-sniffer-annotations-1.16.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/lz4-1.3.0.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/jopt-simple-4.6.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/ratis-common-0.3.0-e6fd494-20180824.092730-1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/jboss-marshalling-1.4.11.Final.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/jmh-core-1.19.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/lib/ratis-proto-shaded-0.3.0-e6fd494-20180824.092643-1.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/hadoop-hdds-container-service-0.2.1-SNAPSHOT.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/hadoop-hdds-server-framework-0.2.1-SNAPSHOT-tests.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/hadoop-hdds-client-0.2.1-SNAPSHOT.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/hadoop-ozone-tools-0.2.1-SNAPSHOT-tests.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/hadoop-hdds-common-0.2.1-SNAPSHOT-tests.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/hadoop-ozone-tools-0.2.1-SNAPSHOT.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/hadoop-hdds-client-0.2.1-SNAPSHOT-tests.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/hadoop-hdds-server-framework-0.2.1-SNAPSHOT.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/hadoop-hdds-common-0.2.1-SNAPSHOT.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/hadoop-hdds-container-service-0.2.1-SNAPSHOT-tests.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/hadoop-hdds-server-scm-0.2.1-SNAPSHOT-tests.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/hadoop-hdds-tools-0.2.1-SNAPSHOT.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/hadoop-hdds-server-scm-0.2.1-SNAPSHOT.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/hdds/hadoop-hdds-tools-0.2.1-SNAPSHOT-tests.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/ozone/hadoop-ozone-client-0.2.1-SNAPSHOT-tests.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/ozone/hadoop-ozone-objectstore-service-0.2.1-SNAPSHOT-tests.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/ozone/hadoop-ozone-client-0.2.1-SNAPSHOT.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/ozone/hadoop-ozone-ozone-manager-0.2.1-SNAPSHOT.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/ozone/hadoop-ozone-common-0.2.1-SNAPSHOT.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/ozone/hadoop-ozone-objectstore-service-0.2.1-SNAPSHOT.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/ozone/hadoop-ozone-common-0.2.1-SNAPSHOT-tests.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/ozone/hadoop-ozone-ozone-manager-0.2.1-SNAPSHOT-tests.jar:/private/tmp/ozone-0.2.1-SNAPSHOT/share/hadoop/ozonefs/hadoop-ozone-filesystem.jar
STARTUP_MSG: build = [e-mail]:apache/hadoop.git -r d53a10b0a552155de700e396fd7f450a4c5f9c22; compiled by 'nmaheshwari' on 2018-08-30T22:33Z
STARTUP_MSG: java = 1.8.0_101
************************************************************/
2018-09-07 12:56:12,406 [main] INFO - registered UNIX signal handlers for [TERM, HUP, INT]
Usage:
ozone om [genericOptions] [ -createObjectStore ]
ozone om [ -help ]


2018-09-07 12:56:12,436 INFO util.ExitUtil: Exiting with status 1: ExitException
2018-09-07 12:56:12,439 [shutdown-hook-0] INFO - SHUTDOWN_MSG:
/************************************************************
SHUTDOWN_MSG: Shutting down OzoneManager at HW11469.local/10.22.16.67
************************************************************/

Ideally all the STARTUP_MSG should not be printed and the output should be like below: 

➜ ozone-0.2.1-SNAPSHOT bin/ozone om -hgfj
Usage:
ozone om [genericOptions] [ -createObjectStore ]
ozone om [ -help ]


2018-09-07 12:56:12,436 INFO util.ExitUtil: Exiting with status 1: ExitException

There should be check in the code to validate the argument first.

Issue Links

• is cloned by: HDDS-452 'ozone scm' with incorrect argument first logs all the STARTUP_MSG