[HDDS-2671] Have NodeManager.getNodeStatus throw NodeNotFoundException

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.5.0
• Fix Version/s: 0.5.0
• Component/s: SCM
• Labels: pull-request-available
• Target Version/s: 0.5.0
• Assignee: Stephen O'Donnell
• Reporter: Stephen O'Donnell
• Created: 05/Dec/19 12:42
• Updated: 24/Feb/20 20:50
• Resolved: 17/Dec/19 18:28

Description

Currently, the SCM node manager method getNodeStatus catches any NodeNotFoundException and returns null.

  /**
   * Returns the node status of a specific node.
   *
   * @param datanodeDetails Datanode Details
   * @return NodeStatus for the node
   */
  @Override
  public NodeStatus getNodeStatus(DatanodeDetails datanodeDetails) {
    try {
      return nodeStateManager.getNodeStatus(datanodeDetails);
    } catch (NodeNotFoundException e) {
      // TODO: should we throw NodeNotFoundException?
      return null;
    }
  }

This should probably throw the exception to ensure downstream code does not need to perform a null check each time it is called.

Issue Links

• links to: GitHub Pull Request #328