[HDDS-2452] Wrong condition for re-scheduling in ReportPublisher

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 0.5.0
• Component/s: Ozone Datanode
• Labels: newbie pull-request-available
• Target Version/s: 0.5.0
• Assignee: Sandeep Nemuri
• Reporter: Attila Doroszlai
• Created: 08/Nov/19 19:37
• Updated: 24/Feb/20 20:51
• Resolved: 13/Nov/19 16:45

Description

It seems the condition for scheduling next run of ReportPublisher is wrong:

https://github.com/apache/hadoop-ozone/blob/master/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/report/ReportPublisher.java#L74-L76

    if (!executor.isShutdown() ||
        !(context.getState() == DatanodeStates.SHUTDOWN)) {
      executor.schedule(this,

Given the condition above, the task may be scheduled again if the executor is shutdown, but the state machine is not set to shutdown (or vice versa). I think the condition should have an &&, not ||. (Currently it is unlikely to happen, since context state is set to shutdown before the report executor.)

nanda, can you please confirm if this is a typo or intentional?

Issue Links

• links to: GitHub Pull Request #151