[HDDS-2349] QueryNode does not respect null values for opState or state

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.5.0
• Fix Version/s: 0.5.0
• Component/s: SCM
• Labels: pull-request-available
• Target Version/s: 0.5.0
• Assignee: Stephen O'Donnell
• Reporter: Stephen O'Donnell
• Created: 23/Oct/19 08:23
• Updated: 24/Feb/20 20:51
• Resolved: 23/Oct/19 20:54

Description

In HDDS-2197, the queryNode API call was changed to allow operational state (in_service, decommissioning etc) to be passed along with the node health state. This changed allowed for a null state to indicate a wildcard, so passing:

opState = null
healthState = HEALTHY

Allows one to find all the healthy nodes, irrespective of their opState.

However, for an enum protobuf field, if no value is specified, the first enum in the set is returned as the default. This means that when a null is passed for opState, only the IN_SERVICE nodes are returned. Similar for health state - passing a null will return only HEALTHY nodes.

This PR will fix this issue so the null value acts as a wildcard as intended.

Issue Links

• links to: GitHub Pull Request #75