[HDDS-210] Make "-file" argument optional for ozone getKey command

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.2.1
• Component/s: Ozone Client

Environment

 

 

• Assignee: Lokesh Jain
• Reporter: Nilotpal Nandi
• Created: 02/Jul/18 11:04
• Updated: 13/Jul/18 18:45
• Resolved: 13/Jul/18 18:45

Description

ozone getKey command always expects the filename to be present along with the file-path for the "-file" argument.

It throws error if  filename is not provided.

 

[root@ozone-vm bin]# ./ozone oz -getKey /nnvolume1/bucket123/passwd -file /test1/
2018-07-02 06:45:27,355 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
Command Failed : {"httpCode":0,"shortMessage":"/test1/exists. Download will overwrite an existing file. Aborting.","resource":null,"message":"/test1/exists. Download will overwrite an existing file. Aborting.","requestID":null,"hostName":null}
[root@ozone-vm bin]# ./ozone oz -getKey /nnvolume1/bucket123/passwd -file /test1/passwd
2018-07-02 06:45:39,722 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
2018-07-02 06:45:40,354 INFO conf.ConfUtils: raft.rpc.type = GRPC (default)
2018-07-02 06:45:40,366 INFO conf.ConfUtils: raft.grpc.message.size.max = 33554432 (custom)
2018-07-02 06:45:40,372 INFO conf.ConfUtils: raft.client.rpc.retryInterval = 300 ms (default)
2018-07-02 06:45:40,374 INFO conf.ConfUtils: raft.client.async.outstanding-requests.max = 100 (default)
2018-07-02 06:45:40,374 INFO conf.ConfUtils: raft.client.async.scheduler-threads = 3 (default)
2018-07-02 06:45:40,507 INFO conf.ConfUtils: raft.grpc.flow.control.window = 1MB (=1048576) (default)
2018-07-02 06:45:40,507 INFO conf.ConfUtils: raft.grpc.message.size.max = 33554432 (custom)
2018-07-02 06:45:40,814 INFO conf.ConfUtils: raft.client.rpc.request.timeout = 3000 ms (default)

 

Expectation :

----------------------

ozone getKey should work even when only file-path is provided (without filename). It should create a file in the given file-path with its key's name as its name.

i.e,

given , /test1 is a directory .

if  ./ozone oz -getKey /nnvolume1/bucket123/passwd -file /test1  is run,

file 'passwd' should be created in the directory /test1 .