[HDDS-1893] Fix bug in removeAcl in Bucket

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 0.4.1
• Component/s: Ozone Manager, Security
• Labels: pull-request-available
• Target Version/s: 0.4.1
• Sprint: Done
• Assignee: Bharat Viswanadham
• Reporter: Bharat Viswanadham
• Created: 02/Aug/19 00:50
• Updated: 05/Aug/19 17:31
• Resolved: 05/Aug/19 17:25

Description

// When we are removing subset of rights from existing acl.
for(OzoneAcl a: bucketInfo.getAcls()) {
 if(a.getName().equals(acl.getName()) &&
 a.getType().equals(acl.getType())) {
 BitSet bits = (BitSet) acl.getAclBitSet().clone();
 bits.and(a.getAclBitSet());

 if (bits.equals(ZERO_BITSET)) {
 return false;
 }
 bits = (BitSet) acl.getAclBitSet().clone();
 bits.and(a.getAclBitSet());
 a.getAclBitSet().xor(bits);

 if(a.getAclBitSet().equals(ZERO_BITSET)) {
 bucketInfo.getAcls().remove(a);
 }
 break;
 } else {
 return false;
 }

In for loop, if first one is not matching with name and type, in else we return false. We should iterate entire acl list and then return response.
}

Issue Links

• links to: GitHub Pull Request #1216