[HDDS-1858] mTLS support for Ozone is not correct

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 0.4.1
• Labels: newbie
• Target Version/s: 0.4.1
• Sprint: Done
• Assignee: Siddharth Wagle
• Reporter: Josh Elser
• Created: 24/Jul/19 22:04
• Updated: 05/Aug/19 14:45
• Resolved: 25/Jul/19 17:05

Description

Thanks to Josh for reporting that we have missing 'Not' in the if condition check.

if (conf.isGrpcMutualTlsRequired()) {
        return new GrpcTlsConfig(
            null, null, conf.getTrustStoreFile(), false);
      } else {
        return new GrpcTlsConfig(conf.getClientPrivateKeyFile(),
            conf.getClientCertChainFile(), conf.getTrustStoreFile(), true);
      }

it should have been

if (!conf.isGrpcMutualTlsRequired()) {
        return new GrpcTlsConfig(
            null, null, conf.getTrustStoreFile(), false);
      } else {
        return new GrpcTlsConfig(conf.getClientPrivateKeyFile(),
            conf.getClientCertChainFile(), conf.getTrustStoreFile(), true);
      }