[HDDS-1800] Result of author check is inverted

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.4.1
• Labels: pull-request-available
• Target Version/s: 0.4.1
• Sprint: Done
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 15/Jul/19 14:14
• Updated: 05/Aug/19 14:46
• Resolved: 15/Jul/19 16:24

Description

What changes were proposed in this pull request?

Fix:

 1. author check fails when no violations are found
 2. author check violations are duplicated in the output

Eg. https://ci.anzix.net/job/ozone-nightly/173/consoleText says that:

The following tests are FAILED:

[author]: author check is failed (https://ci.anzix.net/job/ozone-nightly/173//artifact/build/author.out/*view*/)

but no actual `@author` tags were found:

$ curl -s 'https://ci.anzix.net/job/ozone-nightly/173//artifact/build/author.out/*view*/' | wc
       0       0       0

How was this patch tested?

$ bash -o pipefail -c 'hadoop-ozone/dev-support/checks/author.sh | tee build/author.out'; echo $?
0

$ wc build/author.out
       0       0       0 build/author.out

$ echo '// @author Tolkien' >> hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManager.java

$ bash -o pipefail -c 'hadoop-ozone/dev-support/checks/author.sh | tee build/author.out'; echo $?
./hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManager.java:// @author Tolkien
1

$ wc build/author.out
       1       3     108 build/author.out

Issue Links

• links to: GitHub Pull Request #1092