Uploaded image for project: 'Apache Ozone'
  1. Apache Ozone
  2. HDDS-505 OzoneManager HA
  3. HDDS-1761

Fix class hierarchy for KeyRequest and FileRequest classes.

Attach filesAttach ScreenshotVotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

      Description

      The patch looks mostly fine to me. A few minor comments. and one type error that needs to be fixed.

      I would like to see the class hierarchy refactored in a follow up patch. OMFileCreateRequest}}should not extend {{OMKeyCreateRequest. Instead they should both extend an abstract class that encapsulates the common functionality.

      Generally deriving from concrete classes is a bad idea.

       

      This Jira is created based on Arpit Agarwal comment during review of HDDS-1731

        Attachments

          Activity

            People

            • Assignee:
              bharat Bharat Viswanadham
              Reporter:
              bharat Bharat Viswanadham

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m

                  Issue deployment