[HDDS-1723] Create new OzoneManagerLock class

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.4.1
• Component/s: Ozone Manager
• Labels: pull-request-available
• Sprint: Done
• Assignee: Bharat Viswanadham
• Reporter: Bharat Viswanadham
• Created: 22/Jun/19 00:05
• Updated: 28/Jun/19 21:32
• Resolved: 25/Jun/19 16:30

Description

This Jira is to use bit manipulation, instead of hashmap in OzoneManager lock logic. And also this Jira follows the locking order based on the document attached to HDDS-1672 jira.

This Jira is created based on anu comment during review of HDDS-1672.

Not a suggestion for this patch. But more of a question, should we just maintain a bitset here, and just flip that bit up and down to see if the lock is held. Or we can just maintain 32 bit integer, and we can easily find if a lock is held by Xoring with the correct mask. I feel that might be super efficient. @nandakumar131 . But as I said let us not do that in this patch.

 

This Jira will add new class, integration of this new class into code will be done in a new jira. 

Clean up of old code also will be done in new jira.

Issue Links

• blocks: HDDS-1672 Improve locking in OzoneManager
• is related to: HDDS-1727 Use generation of resourceName for locks in OzoneManagerLock
• links to: GitHub Pull Request #1006