[HDDS-11491] DirectoryDeletion task ignored via ratis

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0, 1.4.1
• Component/s: OM
• Target Version/s: 2.0.0, 1.4.1
• Assignee: Sumit Agrawal
• Reporter: Sumit Agrawal
• Created: 27/Sep/24 06:01
• Updated: 5 days ago 10:53
• Resolved: 01/Oct/24 05:52

Description

Observed certain task of Directory deletion is ignored, and retry same directory again.

Issue:

Ratis avoid submit request (considering replay) for condition if "clientId" and callID is same.

AbstractKeyDeletingService:

private static ClientId clientId = ClientId.randomId();

This is derived by DirectoryDeletingService, KeyDeletingService, ...

CallId is separate object for each derived class, but if callId update is in same/similar pace for all, can cause ignoring of ratis submit (considering replay).

This got hit when the service deletion period is made same of 1min each.

As fix, need to make clientId specific to each service.

 

Issue Links

• links to: GitHub Pull Request #7250