[HDDS-11449] Ambigious "Ignoring ozone.fs.hsync.enabled because HBase enhancements are disallowed" logs

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Labels: pull-request-available
• Assignee: Ashish Kumar
• Reporter: Pratyush Bhatt
• Created: 11/Sep/24 08:23
• Updated: 11/Sep/24 21:30
• Resolved: 11/Sep/24 18:31

Description

HDDS-11342 added a Master config so that all HBase-related enhancements would be disabled (disallowed) when this config is set to false.

It adds a Warn message if any of the config is having a non-default value:

When any of the configs listed above has a value other than the one above, a warning-level message will be printed that prompts the user to flip the config if they want to enable the feature. 

Looks like there is a bug here.
The defaults are as follows as per the JIRA:

ozone.fs.hsync.enabled = false
ozone.client.incremental.chunk.list = false
ozone.client.stream.putblock.piggybacking = false
ozone.client.key.write.concurrency = 1 

I was running a fs -cp command, and it had logs like below:

2024-09-10 18:21:52 WARN helpers.OzoneFSUtils: Ignoring ozone.fs.hsync.enabled = false because HBase enhancements are disallowed. To enable it, set ozone.client.hbase.enhancements.allowed = true as well.
2024-09-10 18:21:53 WARN helpers.OzoneFSUtils: Ignoring ozone.fs.hsync.enabled = false because HBase enhancements are disallowed. To enable it, set ozone.client.hbase.enhancements.allowed = true as well.
2024-09-10 18:21:53 WARN helpers.OzoneFSUtils: Ignoring ozone.fs.hsync.enabled = false because HBase enhancements are disallowed. To enable it, set ozone.client.hbase.enhancements.allowed = true as well.
2024-09-10 18:21:53 WARN helpers.OzoneFSUtils: Ignoring ozone.fs.hsync.enabled = false because HBase enhancements are disallowed. To enable it, set ozone.client.hbase.enhancements.allowed = true as well.
2024-09-10 18:21:53 WARN helpers.OzoneFSUtils: Ignoring ozone.fs.hsync.enabled = false because HBase enhancements are disallowed. To enable it, set ozone.client.hbase.enhancements.allowed = true as well.
2024-09-10 18:21:53 WARN helpers.OzoneFSUtils: Ignoring ozone.fs.hsync.enabled = false because HBase enhancements are disallowed. To enable it, set ozone.client.hbase.enhancements.allowed = true as well.

This to me doesn't make sense, as the config is in its default value and still this is thrown which is pretty obvious from the logs.

And other problem is that these WARN logs are bombarded. They should only come once per command/operation.

cc: siyao  ashishkr weichiu 

Issue Links

• relates to: HDDS-11445 HBase support Phase II
• links to: GitHub Pull Request #7184