[HDDS-11253] Handle corrupted merkle tree files

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Labels: pull-request-available
• Assignee: Ethan Rose
• Reporter: Ethan Rose
• Created: 30/Jul/24 16:17
• Updated: 10/Sep/24 17:44
• Resolved: 10/Sep/24 17:44

Description

A merkle tree file may be corrupted during write or by some other error. This should only be a temporary problem since the scanner will rewrite it on its next run. Until that happens failures should be handled accordingly:

• Clients calling the readMerkleTree API should be able to cleanly fail on a corrupted file. The server does not deserialize it before sending.
• Reconciliation should regenerate a local checksum file if it is corrupted, as if it does not exist.
• File write can be done by renaming a temp file into place to avoid corruption from partial writes. The file would either be present or absent if a write fails, but not partially written.
• Tests using corrupted files should be added.
   

Issue Links

• links to: GitHub Pull Request #7083