[HDDS-11139] Avoid unnecessary object creation in OM request validator

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Implemented
• Fix Version/s: 2.0.0
• Component/s: Ozone Manager
• Labels: pull-request-available
• Target Version/s: 2.0.0
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 11/Jul/24 03:42
• Updated: 12/Jul/24 05:33
• Resolved: 12/Jul/24 05:33

Description

Conversion is unnecessary:

https://github.com/apache/ozone/blob/975a8d85a343a3b7a971b6798493280684456136/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/validation/RequestValidations.java#L68

    OMRequest validatedRequest = request.toBuilder().build();

Default value can be created lazily (only if not found in map):

https://github.com/apache/ozone/blob/975a8d85a343a3b7a971b6798493280684456136/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/validation/ValidatorRegistry.java#L181-L188

  private <K, V> V getAndInitialize(K key, V defaultValue, Map<K, V> from) {
    V inMapValue = from.get(key);
    if (inMapValue == null || !from.containsKey(key)) {
      from.put(key, defaultValue);
      return defaultValue;
    }
    return inMapValue;
  }

Issue Links

• links to: GitHub Pull Request #6926