Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Implemented
    • None
    • 2.0.0
    • OM

    Description

      As per this comment:

      https://github.com/apache/ozone/pull/6385#discussion_r1594869863

      We need to decide how ownership of keys overwritten should work. Probably it is best to let them be owned by their original owner, rather than a possible Admin user who rewrites them.

      Attachments

        Activity

          Upon reviewing the code, the "owner" field is only set at the OM server side when a new key is created. In the case a key is overwritten, the owner is never retrieved from the keyargs and hence overwriting the owner when overwriting a key is not possible. This is the case, both prior to the atomic key overwrite feature and when the traditional key overwrite where a new version is allocated.

          Therefore this change should simply remove the owner details from being passed in the rewrite key and the owner will continue to be inherited as it is now.

          sodonnell Stephen O'Donnell added a comment - Upon reviewing the code, the "owner" field is only set at the OM server side when a new key is created. In the case a key is overwritten, the owner is never retrieved from the keyargs and hence overwriting the owner when overwriting a key is not possible. This is the case, both prior to the atomic key overwrite feature and when the traditional key overwrite where a new version is allocated. Therefore this change should simply remove the owner details from being passed in the rewrite key and the owner will continue to be inherited as it is now.

          People

            sodonnell Stephen O'Donnell
            sodonnell Stephen O'Donnell
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: