[HDDS-10753] OmKeyInfo#acls and WithMetadata#metadata are not thread safe

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Component/s: OM
• Labels: pull-request-available
• Assignee: Tsz-wo Sze
• Reporter: Tsz-wo Sze
• Created: 25/Apr/24 18:14
• Updated: 26/Apr/24 15:22
• Resolved: 26/Apr/24 07:16

Description

XiChen pointed out in this comment that OMKeyInfo#copyObject is just a shallow copy. It is not thread safe since OmKeyInfo#acls is just an ArrayList.

Similarly, WithMetadata#metadata is also not thread safe.

Issue Links

• fixes: HDDS-10520 Fix parameter number warning in OmVolumeArgs
• links to: GitHub Pull Request #6591