[HDDS-10631] Any open key rename should ideally be blocked

• Type: Sub-task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Siyao Meng
• Created: 01/Apr/24 23:13
• Updated: 10/Sep/24 18:16

Description

Currently only hsync'ed open key rename will be blocked with the check:

      if (fromKeyFileStatus.getKeyInfo().isHsync()) {
        throw new OMException("Open file cannot be renamed since it is " +
            "hsync'ed: volumeName=" + volumeName + ", bucketName=" +
            bucketName + ", key=" + fromKeyName, RENAME_OPEN_FILE);
      }

above snippet from https://github.com/apache/ozone/blob/cca6782d44a1417ac27897890eaac5cd097481de/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRenameRequestWithFSO.java#L129-L133

But we should ideally block any open key rename because any writes after that will fail. And because of that, the delayed exception in subsequent write only makes debugging harder

Research to be done:

1. How are directory renames done in FSO buckets? Would this make it slower since it might be required to scan the whole openKeyTable (openFileTable) for that?

Note:

1. This would no longer be needed if/when Ozone supports writes after renames (i.e. client no longer rely on key path, but use something other identifiers such as key object ID / inode
ID)