[HDDS-10590] SstFilteringService updating snapshotInfo directly

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0, 1.4.1
• Labels: pull-request-available
• Target Version/s: 1.4.1
• Assignee: Hemant Kumar
• Reporter: Hemant Kumar
• Created: 26/Mar/24 18:51
• Updated: 24/Apr/24 14:35
• Resolved: 03/Apr/24 23:15

Description

SstFilteringService marks the sstFilter flag for a snapshot and updates the RocksDB, code. It may cause snapshot chain corruption (probably not after the fix: https://github.com/apache/ozone/pull/6443) or data inconsistency due to race condition because SstFilteringService updates snapshot info in parallel to SnapshotPurge and SnapshotProperty which also update snapshot info. Even tho SstFilteringService takes a lock before updating snapshotInfo, SnapshotPurge and SnapshotProperty APIs don't take a lock and rely on OMStateMachine because OMStateMachine is going to process each request sequentially.
In general, each update to snapshotInfoTable should go through API but that is not possible for SstFilteringService because SstFilteringService runs on each OM independently. Hence it is directly updating snapshotInfoTable.
So we need to introduce the lock for SnapshotPurge and SetSnapshotProperty APIs unless there is another better way.

Issue Links

• links to: GitHub Pull Request #6456