Uploaded image for project: 'Apache Ozone'
  1. Apache Ozone
  2. HDDS-10482

OMRequestTestUtils.createOmKeyInfo should set key modification time

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.5.0
    • test

    Description

      HDDS-10226 refactoring forgot to set modification time for OMRequestTestUtils.createOmKeyInfo. This causes one test (regarding lease recovery on the feature branch) to fail:

      Error:  Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.981 s <<< FAILURE! - in org.apache.hadoop.ozone.om.request.file.TestOMRecoverLeaseRequest
      Error:  org.apache.hadoop.ozone.om.request.file.TestOMRecoverLeaseRequest.testLeaseSoftLimitForHsyncRecoverFile(boolean)[2]  Time elapsed: 0.215 s  <<< FAILURE!
      org.opentest4j.AssertionFailedError: expected: <KEY_UNDER_LEASE_SOFT_LIMIT_PERIOD> but was: <OK>
      	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
      	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
      	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
      	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
      	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
      	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
      	at org.apache.hadoop.ozone.om.request.file.TestOMRecoverLeaseRequest.testLeaseSoftLimitForHsyncRecoverFile(TestOMRecoverLeaseRequest.java:325)
      

      Since this counts as a regression on the master branch. This would target master branch rather than the feature branch that has the test failure.

      Attachments

        Issue Links

          Activity

            People

              smeng Siyao Meng
              smeng Siyao Meng
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: