[HDDS-10471] [hsync] MockDatanodeStorage.writeChunk should make a copy of byte string

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: HDDS-7593
• Labels: pull-request-available
• Assignee: Wei-Chiu Chuang
• Reporter: Wei-Chiu Chuang
• Created: 05/Mar/24 23:39
• Updated: 06/Mar/24 19:44
• Resolved: 06/Mar/24 18:55

Description

MockDatanodeStorage.writeChunk simply adds the bytestring chunk info into its internal map, and after HDDS-9843 which made chunk buffer direct buffer, it causes some sort of memory corruption as described in HDDS-10431. Suspect it's a JVM bug.

Solution is simple: make a copy of the byte buffer.

Thanks smeng for narrowing down the culprit.

Issue Links

• is caused by: HDDS-9751 [hsync] Make Putblock performance acceptable - DataNode side
• links to: GitHub Pull Request #6334