[HDDS-10184] Fix ManagedStatistics not closed properly

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.4.0
• Fix Version/s: 1.5.0, 1.4.1
• Component/s: OM, Ozone Datanode
• Labels: pull-request-available
• Target Version/s: 1.4.1
• Assignee: Hongbing Wang Assign to me
• Reporter: Hongbing Wang
• Created: 22/Jan/24 12:18
• Updated: 29/Jan/24 09:51
• Resolved: 25/Jan/24 08:52

Description

When set config:

   <property>
      <name>ozone.metastore.rocksdb.statistics</name>
      <value>ALL</value>
   </property> 

OM ManagedStatistics not closed properly:

2024-01-22 18:34:22,137 [LeakDetector-ManagedRocksObject0] WARN org.apache.hadoop.hdds.utils.db.managed.ManagedRocksObjectUtils: ManagedStatistics is not closed properly
StackTrace for unclosed instance: org.apache.hadoop.hdds.utils.db.managed.ManagedStatistics.<init>(ManagedStatistics.java:30)
org.apache.hadoop.hdds.utils.db.DBStoreBuilder.getDefaultDBOptions(DBStoreBuilder.java:418)
org.apache.hadoop.hdds.utils.db.DBStoreBuilder.build(DBStoreBuilder.java:209)
org.apache.hadoop.ozone.om.OmMetadataManagerImpl.loadDB(OmMetadataManagerImpl.java:607)
org.apache.hadoop.ozone.om.OmMetadataManagerImpl.loadDB(OmMetadataManagerImpl.java:570)
org.apache.hadoop.ozone.om.OmMetadataManagerImpl.start(OmMetadataManagerImpl.java:560)
org.apache.hadoop.ozone.om.OmMetadataManagerImpl.<init>(OmMetadataManagerImpl.java:342)
org.apache.hadoop.ozone.om.OzoneManager.instantiateServices(OzoneManager.java:803)
org.apache.hadoop.ozone.om.OzoneManager.<init>(OzoneManager.java:683)
org.apache.hadoop.ozone.om.OzoneManager.createOm(OzoneManager.java:768)
org.apache.hadoop.ozone.om.OzoneManagerStarter$OMStarterHelper.start(OzoneManagerStarter.java:189)
org.apache.hadoop.ozone.om.OzoneManagerStarter.startOm(OzoneManagerStarter.java:86) 

DN ManagedStatistics not closed properly:

2024-01-22 19:51:22,414 [LeakDetector-ManagedRocksObject0] WARN org.apache.hadoop.hdds.utils.db.managed.ManagedRocksObjectUtils: ManagedStatistics is not closed properly
StackTrace for unclosed instance: org.apache.hadoop.hdds.utils.db.managed.ManagedStatistics.<init>(ManagedStatistics.java:30)
org.apache.hadoop.ozone.container.metadata.AbstractDatanodeStore.start(AbstractDatanodeStore.java:121)
org.apache.hadoop.ozone.container.metadata.AbstractDatanodeStore.<init>(AbstractDatanodeStore.java:99)
org.apache.hadoop.ozone.container.metadata.DatanodeStoreSchemaThreeImpl.<init>(DatanodeStoreSchemaThreeImpl.java:66)
org.apache.hadoop.ozone.container.keyvalue.helpers.BlockUtils.getUncachedDatanodeStore(BlockUtils.java:85)
org.apache.hadoop.ozone.container.common.utils.HddsVolumeUtil.initPerDiskDBStore(HddsVolumeUtil.java:74)
org.apache.hadoop.ozone.container.common.volume.HddsVolume.loadDbStore(HddsVolume.java:365)
org.apache.hadoop.ozone.container.common.utils.HddsVolumeUtil.loadVolume(HddsVolumeUtil.java:111)
org.apache.hadoop.ozone.container.common.utils.HddsVolumeUtil.lambda$loadAllHddsVolumeDbStore$0(HddsVolumeUtil.java:97)
java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1626)
java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1618)
java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) 

Issue Links

• links to: GitHub Pull Request #6055