Uploaded image for project: 'Apache Ozone'
  1. Apache Ozone
  2. HDDS-10181

Remove duplicate ACL protobuf definitions in interface-storage

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Won't Do
    • 1.4.0
    • None
    • OM

    Description

      It's observed that the serialization (toProtobuf) and deserialization (fromProtobuf) of OmPrefixInfo uses OzoneAclStorageUtil, whereas OmKeyInfo, OmBucketInfo, OmVolumeArgs uses OzoneAclUtil. The logic for both classes looks the same.

      There are also duplicate proto definitions for OzoneAclInfo in OmStorageProtocol.proto and OmClientProtocol.proto.

      We need to remove the duplication to prevent any divergence.

      Note: This seems the separation was done as part of HDDS-4242, under HDDS-4216 which are supposed to separate RPC and storage proto files for compatibility reasons by introducing interface-storage package. But it seems only PrefixInfo and UserVolumeInfo have been done for this. If these changes are intended, this can be closed and we can focus on separating the remaining protos instead.

      Attachments

        Issue Links

          Activity

            People

              ivanandika Ivan Andika
              ivanandika Ivan Andika
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: