Details
-
Improvement
-
Status: In Progress
-
Minor
-
Resolution: Unresolved
-
1.3.0
-
None
Description
There is logic for checking key names in OMFileCreateRequest, OMKeyCommitRequest, OMKeyCreateRequest, and OMKeyRenameRequest.
OMFileCreateRequest:
final boolean checkKeyNameEnabled = ozoneManager.getConfiguration() .getBoolean(OMConfigKeys.OZONE_OM_KEYNAME_CHARACTER_CHECK_ENABLED_KEY, OMConfigKeys.OZONE_OM_KEYNAME_CHARACTER_CHECK_ENABLED_DEFAULT); if (checkKeyNameEnabled) { OmUtils.validateKeyName(StringUtils.removeEnd(keyArgs.getKeyName(), OzoneConsts.FS_FILE_COPYING_TEMP_SUFFIX)); }
OnKeyCommitRequest:
final boolean checkKeyNameEnabled = ozoneManager.getConfiguration() .getBoolean(OMConfigKeys.OZONE_OM_KEYNAME_CHARACTER_CHECK_ENABLED_KEY, OMConfigKeys.OZONE_OM_KEYNAME_CHARACTER_CHECK_ENABLED_DEFAULT); if (checkKeyNameEnabled) { OmUtils.validateKeyName(StringUtils.removeEnd(keyArgs.getKeyName(), OzoneConsts.FS_FILE_COPYING_TEMP_SUFFIX)); }
We can unify them.
Attachments
Issue Links
- links to