Uploaded image for project: 'Apache Ozone'
  1. Apache Ozone
  2. HDDS-10133

Add a method to check key name in OMKeyRequest

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: In Progress
    • Minor
    • Resolution: Unresolved
    • 1.3.0
    • None
    • OM

    Description

      There is logic for checking key names in OMFileCreateRequest, OMKeyCommitRequest, OMKeyCreateRequest, and OMKeyRenameRequest.
      OMFileCreateRequest:

      final boolean checkKeyNameEnabled = ozoneManager.getConfiguration()
               .getBoolean(OMConfigKeys.OZONE_OM_KEYNAME_CHARACTER_CHECK_ENABLED_KEY,
                       OMConfigKeys.OZONE_OM_KEYNAME_CHARACTER_CHECK_ENABLED_DEFAULT);
          if (checkKeyNameEnabled) {
            OmUtils.validateKeyName(StringUtils.removeEnd(keyArgs.getKeyName(),
                    OzoneConsts.FS_FILE_COPYING_TEMP_SUFFIX));
          }
      

      OnKeyCommitRequest:

      final boolean checkKeyNameEnabled = ozoneManager.getConfiguration()
               .getBoolean(OMConfigKeys.OZONE_OM_KEYNAME_CHARACTER_CHECK_ENABLED_KEY,
                       OMConfigKeys.OZONE_OM_KEYNAME_CHARACTER_CHECK_ENABLED_DEFAULT);
          if (checkKeyNameEnabled) {
            OmUtils.validateKeyName(StringUtils.removeEnd(keyArgs.getKeyName(),
                    OzoneConsts.FS_FILE_COPYING_TEMP_SUFFIX));
          }
      

      We can unify them.

      Attachments

        Issue Links

          Activity

            People

              jianghuazhu JiangHua Zhu
              jianghuazhu JiangHua Zhu
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: