[HDDS-10078] Parameterize TestOmMetrics#testKeyOps across bucket layouts

• Type: Sub-task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: OM, test
• Assignee: Unassigned
• Reporter: Ethan Rose
• Created: 06/Jan/24 01:14
• Updated: 08/Jan/24 20:30

Description

Currently TestOmMetrics#testKeyOps is only tested against LEGACY bucket layout. We should test it against FSO, OBS, and LEGACY. I was planning to add this in HDDS-10063, but ran into an issue with running the test on an FSO bucket and decided to move it to a different jira.

The issue with the FSO bucket is due to the fault injection that happens partway through the test. This causes the NumKeyDeletes counter to not get incremented on the fourth key delete, because a KEY_NOT_FOUND OMException is raised when this line in OmFileRequest returns null while trying to get the key to check its ACLs in pre-execute. Other bucket layouts do not have this problem.

Issue Links

• Discovered while testing: HDDS-10063 NumKeys metric not decremented on FSO directory delete
• is related to: HDDS-10084 Replace LEGACY in integration test with default layout from config
• relates to: HDDS-9388 OM Ratis Write: Move ACL check and Bucket resolution to preExecute