[HDDS-10019] Simplify updateLastAppliedIndex in OzoneManagerStateMachine

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: OM HA
• Assignee: Tsz-wo Sze
• Reporter: Tsz-wo Sze
• Created: 27/Dec/23 11:40
• Updated: 01/Mar/24 19:22
• Resolved: 01/Mar/24 19:22

Description

HDDS-2680 added some complicated logic to updateLastAppliedIndex. It leads to some bugs like HDDS-9342.

This JIRA is to investigate some ways to simplify the logic. In particular, we should remove data structure / interface like

• OzoneManagerStateMachine
  • applyTransactionMap
  • ratisTransactionMap
• OzoneManagerDoubleBuffer
  • indexToTerm (HDDS-10006)
  • ozoneManagerRatisSnapShot
  • currentFutureQueue
  • readyFutureQueue

Issue Links

• relates to: HDDS-9342 OM restart failed due to transactionLogIndex smaller than current updateID
• relates to: HDDS-2680 Fix updating lastAppliedIndex in OzoneManagerStateMachine

Sub-Tasks

• Pass TransactionInfo in OzoneManagerRequestHandler.handleWriteRequest: Resolved
• DoubleBufferEntry should not be generic: Resolved
• Remove current/readyFutureQueue from OzoneManagerDoubleBuffer: Resolved
• Remove the flushLatches set from FlushNotifier: Resolved
• Remove applyTransactionMap and ratisTransactionMap from OzoneManagerStateMachine: Resolved
• Remove maxFlushedTransactionsInOneIteration from OzoneManagerDoubleBuffer: Resolved
• Do not start the daemon inside the OzoneManagerDoubleBuffer constructor: Resolved
• Fix checkstyle:parameternumber in OzoneManagerDoubleBuffer: Resolved
• OM startup failure as leader is not getting ready: Resolved