[HDDS-10007] Rename ManagedSstFileReader in rocksdb-checkpoint-differ

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.0
• Fix Version/s: 1.5.0
• Component/s: Snapshot
• Labels: pull-request-available
• Target Version/s: 1.5.0
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 23/Dec/23 09:38
• Updated: 29/Dec/23 18:25
• Resolved: 29/Dec/23 18:25

Description

https://github.com/apache/ozone/blob/f9167a359e7ff6f54eafc8a7b1c3fd165050160f/hadoop-hdds/managed-rocksdb/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedSstFileReader.java#L23-L26

/**
 * Managed SstFileReader.
 */
public class ManagedSstFileReader extends ManagedObject<SstFileReader> {

https://github.com/apache/ozone/blob/f9167a359e7ff6f54eafc8a7b1c3fd165050160f/hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdb/util/ManagedSstFileReader.java#L48-L52

/**
 * ManagedSstFileReader provides an abstraction layer using which we can
 * iterate over multiple underlying SST files transparently.
 */
public class ManagedSstFileReader {

ManagedSstFileReader in rocksdb-checkpoint-differ should be renamed to avoid confusion with the "real" ManagedSstFileReader from hdds-managed-rocksdb.

I think SstFileSetReader would be a better name.

Issue Links

• links to: GitHub Pull Request #5859