Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.3
    • 0.3
    • None

    Description

      This jira deals with creating a class which defined a snapshot for HCatalog tables.

      Attachments

        1. HCatalog-core-04.patch
          3 kB
          Vandana Ayyalasomayajula
        2. HCatalog-snapshot.patch
          3 kB
          Vandana Ayyalasomayajula
        3. HCatalog-snapshot.02.patch
          3 kB
          Vandana Ayyalasomayajula

        Issue Links

          Activity

            gates Alan Gates added a comment -

            Issue closed with 0.4 release.

            gates Alan Gates added a comment - Issue closed with 0.4 release.

            committed to trunk and branch-0.3. Thanks Vandana.

            toffer Francis Christopher Liu added a comment - committed to trunk and branch-0.3. Thanks Vandana.

            -----------------------------------------------------------
            This is an automatically generated e-mail. To reply, visit:
            https://reviews.apache.org/r/2811/#review4428
            -----------------------------------------------------------

            /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HCatTableSnapshot.java
            <https://reviews.apache.org/r/2811/#comment9938>

            As previously discussed we want this object to be opaque. So can you make constructor, getRevision, containsColumn into package-private?

            • Francis

            On 2012-01-14 01:09:59, Vandana Ayyalasomayajula wrote:

            -----------------------------------------------------------

            This is an automatically generated e-mail. To reply, visit:

            https://reviews.apache.org/r/2811/

            -----------------------------------------------------------

            (Updated 2012-01-14 01:09:59)

            Review request for hcatalog, Francis Liu and David Capwell.

            Summary

            -------

            This class defines a snapshot for HCatalog tables. This is required in Hcatalog map reduce package for revision management.

            This addresses bug hcatalog-193.

            https://issues.apache.org/jira/browse/hcatalog-193

            Diffs

            -----

            /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HCatTableSnapshot.java PRE-CREATION

            Diff: https://reviews.apache.org/r/2811/diff

            Testing

            -------

            The test case in HBase storage drivers covers this class. The unit tests pass.

            Thanks,

            Vandana

            jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2811/#review4428 ----------------------------------------------------------- /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HCatTableSnapshot.java < https://reviews.apache.org/r/2811/#comment9938 > As previously discussed we want this object to be opaque. So can you make constructor, getRevision, containsColumn into package-private? Francis On 2012-01-14 01:09:59, Vandana Ayyalasomayajula wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2811/ ----------------------------------------------------------- (Updated 2012-01-14 01:09:59) Review request for hcatalog, Francis Liu and David Capwell. Summary ------- This class defines a snapshot for HCatalog tables. This is required in Hcatalog map reduce package for revision management. This addresses bug hcatalog-193. https://issues.apache.org/jira/browse/hcatalog-193 Diffs ----- /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HCatTableSnapshot.java PRE-CREATION Diff: https://reviews.apache.org/r/2811/diff Testing ------- The test case in HBase storage drivers covers this class. The unit tests pass. Thanks, Vandana

            -----------------------------------------------------------
            This is an automatically generated e-mail. To reply, visit:
            https://reviews.apache.org/r/2811/
            -----------------------------------------------------------

            (Updated 2012-01-14 01:09:59.076191)

            Review request for hcatalog, Francis Liu and David Capwell.

            Changes
            -------

            The HCatalog snapshot class can be placed in the hbase storage driver package as it is only used by the storage driver.

            Summary
            -------

            This class defines a snapshot for HCatalog tables. This is required in Hcatalog map reduce package for revision management.

            This addresses bug hcatalog-193.
            https://issues.apache.org/jira/browse/hcatalog-193

            Diffs (updated)


            /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HCatTableSnapshot.java PRE-CREATION

            Diff: https://reviews.apache.org/r/2811/diff

            Testing
            -------

            The test case in HBase storage drivers covers this class. The unit tests pass.

            Thanks,

            Vandana

            jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2811/ ----------------------------------------------------------- (Updated 2012-01-14 01:09:59.076191) Review request for hcatalog, Francis Liu and David Capwell. Changes ------- The HCatalog snapshot class can be placed in the hbase storage driver package as it is only used by the storage driver. Summary ------- This class defines a snapshot for HCatalog tables. This is required in Hcatalog map reduce package for revision management. This addresses bug hcatalog-193. https://issues.apache.org/jira/browse/hcatalog-193 Diffs (updated) /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HCatTableSnapshot.java PRE-CREATION Diff: https://reviews.apache.org/r/2811/diff Testing ------- The test case in HBase storage drivers covers this class. The unit tests pass. Thanks, Vandana
            dcapwell David Capwell added a comment -

            +1

            dcapwell David Capwell added a comment - +1

            -----------------------------------------------------------
            This is an automatically generated e-mail. To reply, visit:
            https://reviews.apache.org/r/2811/#review4188
            -----------------------------------------------------------

            Ship it!

            Looks good to me. With our without the changes below I think this is fine.

            /trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableSnapshot.java
            <https://reviews.apache.org/r/2811/#comment9440>

            I would put DB before Table to be more consistent with the cli (mydb.mytable)

            /trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableSnapshot.java
            <https://reviews.apache.org/r/2811/#comment9441>

            I would put DB before Table to be more consistent with the CLi.

            • David

            On 2011-12-22 00:56:38, Vandana Ayyalasomayajula wrote:

            -----------------------------------------------------------

            This is an automatically generated e-mail. To reply, visit:

            https://reviews.apache.org/r/2811/

            -----------------------------------------------------------

            (Updated 2011-12-22 00:56:38)

            Review request for hcatalog, Francis Liu and David Capwell.

            Summary

            -------

            This class defines a snapshot for HCatalog tables. This is required in Hcatalog map reduce package for revision management.

            This addresses bug hcatalog-193.

            https://issues.apache.org/jira/browse/hcatalog-193

            Diffs

            -----

            /trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableSnapshot.java PRE-CREATION

            Diff: https://reviews.apache.org/r/2811/diff

            Testing

            -------

            The test case in HBase storage drivers covers this class. The unit tests pass.

            Thanks,

            Vandana

            jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2811/#review4188 ----------------------------------------------------------- Ship it! Looks good to me. With our without the changes below I think this is fine. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableSnapshot.java < https://reviews.apache.org/r/2811/#comment9440 > I would put DB before Table to be more consistent with the cli (mydb.mytable) /trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableSnapshot.java < https://reviews.apache.org/r/2811/#comment9441 > I would put DB before Table to be more consistent with the CLi. David On 2011-12-22 00:56:38, Vandana Ayyalasomayajula wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2811/ ----------------------------------------------------------- (Updated 2011-12-22 00:56:38) Review request for hcatalog, Francis Liu and David Capwell. Summary ------- This class defines a snapshot for HCatalog tables. This is required in Hcatalog map reduce package for revision management. This addresses bug hcatalog-193. https://issues.apache.org/jira/browse/hcatalog-193 Diffs ----- /trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableSnapshot.java PRE-CREATION Diff: https://reviews.apache.org/r/2811/diff Testing ------- The test case in HBase storage drivers covers this class. The unit tests pass. Thanks, Vandana

            -----------------------------------------------------------
            This is an automatically generated e-mail. To reply, visit:
            https://reviews.apache.org/r/2811/
            -----------------------------------------------------------

            (Updated 2011-12-22 00:56:38.400373)

            Review request for hcatalog, Francis Liu and David Capwell.

            Summary (updated)
            -------

            This class defines a snapshot for HCatalog tables. This is required in Hcatalog map reduce package for revision management.

            This addresses bug hcatalog-193.
            https://issues.apache.org/jira/browse/hcatalog-193

            Diffs (updated)


            /trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableSnapshot.java PRE-CREATION

            Diff: https://reviews.apache.org/r/2811/diff

            Testing (updated)
            -------

            The test case in HBase storage drivers covers this class. The unit tests pass.

            Thanks,

            Vandana

            jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2811/ ----------------------------------------------------------- (Updated 2011-12-22 00:56:38.400373) Review request for hcatalog, Francis Liu and David Capwell. Summary (updated) ------- This class defines a snapshot for HCatalog tables. This is required in Hcatalog map reduce package for revision management. This addresses bug hcatalog-193. https://issues.apache.org/jira/browse/hcatalog-193 Diffs (updated) /trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableSnapshot.java PRE-CREATION Diff: https://reviews.apache.org/r/2811/diff Testing (updated) ------- The test case in HBase storage drivers covers this class. The unit tests pass. Thanks, Vandana

            People

              avandana Vandana Ayyalasomayajula
              avandana Vandana Ayyalasomayajula
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: