A little late to the party... Started taking a look at this and its a BIG patch. Its basically unreviewably large. My 2c is addressing only blocking issues and getting this checked in ASAP. In the future it would we awesome to just do development of new components in trunk so all code uses the regular process.
Comments from before I started skimming:
- What do you think about using a sized-based log rotation config by default? What I see in production are spammy log lines that cause disks to fill up in less than a day. Daily is handy for developers doing debug stuff because you can find logs quickly, but to guard against full disks the sized-based configs are preferable.
- INFO by default?
Here we see some lines with version numbers. Do these accept globs? I can see this being a source of misconfiguration where libraries are upgraded, a deploy happens, and the config becomes outdated. The code and configs are often not pushed out together.
<description>The path to the Templeton jar file.</description>
Is there a good reason not to use HADOOP_HOME? Same with HCAT_PREFIX (why not use HCAT_HOME)?
<description>The path to the Hadoop executable.</description>
There are some properties that do not include units. This often leads to misconfigurations.
<description>The maximum age of a templeton job</description>